Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove low level ingester client settings #1153

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

pracucci
Copy link
Collaborator

What this PR does:
We have 3 low level settings which we don't set in our jsonnet. I propose to just get rid of them and keep using the hardcoded defaults:

  • -ingester-client.expected-labels
  • -ingester-client.expected-samples-per-series
  • -ingester-client.expected-timeseries

Which issue(s) this PR fixes:
N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Member

@pstibrany pstibrany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

@bboreham
Copy link
Contributor

Arguably expectedTimeseries should equal the Prometheus default of 500.
I don’t think it matters much since the allocations are reused in a pool so the pool will tend to hold the biggest size used.

@pracucci
Copy link
Collaborator Author

pracucci commented Feb 10, 2022

Arguably expectedTimeseries should equal the Prometheus default of 500.
I don’t think it matters much since the allocations are reused in a pool so the pool will tend to hold the biggest size used.

👍 Tracked in a issue: #1154 (I prefer to keep this PR about CLI flag removal)

@pracucci pracucci merged commit 4288152 into main Feb 10, 2022
@pracucci pracucci deleted the remove-ingester-client-low-level-params branch February 10, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants