Alertmanager: Remove upstream clustering (gossip) operation. #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevesg
force-pushed
the
remove-alertmanager-no-sharding-mode
branch
from
9b79d1a
to
ec6987a
Compare
stevesg
changed the title
stevesg
force-pushed
the
remove-alertmanager-no-sharding-mode
branch
from
ec6987a
to
f1c4aec
Compare
pstibrany
approved these changes
Feb 9, 2022
stevesg
force-pushed
the
remove-alertmanager-no-sharding-mode
branch
from
f1c4aec
to
ef8c975
Compare
stevesg
changed the title
stevesg
force-pushed
the
remove-alertmanager-no-sharding-mode
branch
2 times, most recently
from
6cfc39b
to
cf0afbd
Compare
This commit removes the ability for alertmanager to be run with the upstream clustering (gossip) functionality. Alertmanager must now be run with sharding enabled. In essence, `-alertmanager.sharding-enabled=true` is now the default. This removes the following configuration options which are no longer needed: - `-alertmanager.sharding-enabled` - `-alertmanager.cluster.advertise-address` - `-alertmanager.cluster.gossip-interval` - `-alertmanager.cluster.listen-address` - `-alertmanager.cluster.peers` - `-alertmanager.cluster.push-pull-interval` Some points of note: - The `state` field of the `Alertmanager` struct is now always of the type `alertmanager.state`, allowing simplification of certain code paths. - The "status" endpoint for Alertmanager which would display the list of peers, now simply shows the service status (Starting, Running, etc). The equivalent information for sharding is found in the ring page. - All remaining unit tests and integration tests which did not run with sharding enabled, have now been ported to work with sharding.
stevesg
force-pushed
the
remove-alertmanager-no-sharding-mode
branch
from
cf0afbd
to
5c7f694
Compare
|
Part of: #856 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the ability for alertmanager to be run with the upstream
clustering (gossip) functionality. Alertmanager must now be run with sharding
enabled. In essence,
-alertmanager.sharding-enabled=trueis now the default.This removes the following configuration options which are no longer needed:
-alertmanager.sharding-enabled-alertmanager.cluster.advertise-address-alertmanager.cluster.gossip-interval-alertmanager.cluster.listen-address-alertmanager.cluster.peers-alertmanager.cluster.push-pull-intervalThe following configuration option is renamed:
-alertmanager.cluster.peer-timeoutto-alertmanager.peer-timeoutSome points of note:
statefield of theAlertmanagerstruct is now always of the typealertmanager.state, allowing simplification of certain code paths.peers, now simply shows the service status (Starting, Running, etc).
The equivalent information for sharding is found in the ring page.
sharding enabled, have now been ported to work with sharding.