Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mentions of obsolete sharding-enabled flags. #1123

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

pstibrany
Copy link
Member

@pstibrany pstibrany commented Feb 8, 2022

What this PR does: This PR updates documentation and removes obsolete sharding-enabled flags from it.

Which issue(s) this PR fixes:

This PR is part of #856.

Checklist

  • [na] Tests updated
  • Documentation added
  • [na] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@pstibrany pstibrany added the type/docs Improvements or additions to documentation label Feb 8, 2022
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (modulo a nit)

docs/sources/guides/sharded_ruler.md Outdated Show resolved Hide resolved
@pracucci
Copy link
Collaborator

pracucci commented Feb 8, 2022

I just realized this PR will conflict with #1117.

@pstibrany pstibrany merged commit 9251587 into main Feb 9, 2022
@pstibrany pstibrany deleted the update-sharding-docs branch February 9, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants