Change default values for local directories #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstibrany
reviewed
Feb 8, 2022
There was a problem hiding this comment.
I think we should improve on flag descriptions:
- file path to store temporary rule files for the prometheus rule managers
- Data directory in which to cache blocks and process compactions
- Base path for data storage.
Once it's "file path" then "data directory" and finally "Base path". I think all three should say roughly the same, that it's a local directory used by given component to store files. We should also be clear about which directories have temporary files only and can be cleaned up, and which have files that need to persist between restarts.
pkg/alertmanager/multitenant.go
Outdated
| @@ -104,7 +104,7 @@ const ( | |||
|
|
|||
| // RegisterFlags adds the flags required to config this to the given FlagSet. | |||
| func (cfg *MultitenantAlertmanagerConfig) RegisterFlags(f *flag.FlagSet) { | |||
| f.StringVar(&cfg.DataDir, "alertmanager.storage.path", "data/", "Base path for data storage.") | |||
| f.StringVar(&cfg.DataDir, "alertmanager.storage.path", "./data-alertmanager/", "Base path for data storage.") | |||
There was a problem hiding this comment.
How exactly is -alertmanager.storage.path used? Is it for local temporary files only? I think this description could improve to say that.
Good idea! I revisited all involved descriptions. Can you take another look, please? |
pstibrany
approved these changes
Feb 8, 2022
osg-grafana
reviewed
Feb 8, 2022
pracucci
force-pushed
the
change-local-dirs-defaults
branch
from
867211f
to
748e1a1
Compare
Signed-off-by: Marco Pracucci <[email protected]>
Signed-off-by: Marco Pracucci <[email protected]>
pracucci
force-pushed
the
change-local-dirs-defaults
branch
from
748e1a1
to
6fa5dbe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
As agreed in #1059, in this PR I'm changing default values for local directories so that they're all based on the CWD and not conflicting each other.
Some notes:
-blocks-storage.tsdb.dirand-blocks-storage.bucket-store.sync-dirare not reported in the CHANGELOG because they're not breaking changed (but we decided to adjust them to make it more clear)-activity-tracker.filepathis not reported in the CHANGELOG because it's a new feature since last release-ruler.rule-path=/rulesto our jsonnet to not introduce a breaking change there. Other settings I've changed are already overridden in the jsonnet.Which issue(s) this PR fixes:
Fixes #1059
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]