Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Change parameter delimiter to parentheses #1068

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

KMiller-Grafana
Copy link
Contributor

In https://github.com/grafana/mimir/blob/main/docs/sources/configuration/config-file-reference.template, we state that square brackets are used in the YAML reference of configuration parameters to denote an optional parameter. So, using square brackets to delimit the parameter category of advanced or experimental would overload the use of square brackets.

This PR changes the square brackets to parentheses. No information is lost. It is just formatted differently.

@osg-grafana osg-grafana added the type/docs Improvements or additions to documentation label Feb 8, 2022
@osg-grafana osg-grafana changed the title Docs: change parameter delimiter to parentheses Docs: Change parameter delimiter to parentheses Feb 8, 2022
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I suggest to get this PR merged as soon as possible, to avoid future conflicts whenever we'll do changes to config.

@jdbaldry jdbaldry merged commit 96c0775 into main Feb 8, 2022
@jdbaldry jdbaldry deleted the docs/change-square-brackets branch February 8, 2022 08:09
@osg-grafana osg-grafana mentioned this pull request Feb 8, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants