diff --git a/CHANGELOG.md b/CHANGELOG.md index fdd8476c93a..1a7994ebc94 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -226,7 +226,7 @@ * [CHANGE] Ruler: removed `-ruler.enable-sharding` option, and change default value of `-ruler.ring.store` to `memberlist`. #943 * [CHANGE] Ruler: `-ruler.alertmanager-use-v2` now defaults to `true`. #954 * [CHANGE] Compactor: Removed `-compactor.sharding-enabled` option. Sharding in compactor is now always enabled. Default value of `-compactor.ring.store` has changed from `consul` to `memberlist`. Default value of `-compactor.ring.wait-stability-min-duration` is now 0, which disables the feature. #956 -* [CHANGE] Changed default settings for memcached clients: #959 +* [CHANGE] Changed default settings for memcached clients: #959 #1000 * The default value for the following config options has changed from `10000` to `25000`: * `-blocks-storage.bucket-store.chunks-cache.memcached.max-async-buffer-size` * `-blocks-storage.bucket-store.index-cache.memcached.max-async-buffer-size` @@ -242,6 +242,11 @@ * `-blocks-storage.bucket-store.index-cache.memcached.max-idle-connections` * `-blocks-storage.bucket-store.metadata-cache.memcached.max-idle-connections` * `-frontend.results-cache.memcached.max-idle-connections` + * The default value for the following config options has changed from `100ms` to `200ms`: + * `-blocks-storage.bucket-store.metadata-cache.memcached.timeout` + * `-blocks-storage.bucket-store.index-cache.memcached.timeout` + * `-blocks-storage.bucket-store.chunks-cache.memcached.timeout` + * `-frontend.results-cache.memcached.timeout` * [CHANGE] Querier: removed `-querier.worker-match-max-concurrent` and `-querier.worker-parallelism` CLI flags (and their respective YAML config options). Mimir now behaves like if `-querier.worker-match-max-concurrent` is always enabled and you should configure the max concurrency per querier process using `-querier.max-concurrent` instead. #958 * [CHANGE] Distributor: change default value of `-distributor.instance-limits.max-inflight-push-requests` to `2000`. #964 * [CHANGE] Distributor: change default value of `-distributor.remote-timeout` from `2s` to `20s`. #970 diff --git a/cmd/mimir/help-all.txt.tmpl b/cmd/mimir/help-all.txt.tmpl index 6771855d5d7..ee6029d0fe2 100644 --- a/cmd/mimir/help-all.txt.tmpl +++ b/cmd/mimir/help-all.txt.tmpl @@ -284,7 +284,7 @@ Usage of ./cmd/mimir/mimir: -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size int The maximum size of an item stored in memcached. Bigger items are not stored. If set to 0, no maximum size is enforced. (default 1048576) -blocks-storage.bucket-store.chunks-cache.memcached.timeout duration - The socket read/write timeout. (default 100ms) + The socket read/write timeout. (default 200ms) -blocks-storage.bucket-store.chunks-cache.subrange-size int Size of each subrange that bucket object is split into for better caching. (default 16000) -blocks-storage.bucket-store.chunks-cache.subrange-ttl duration @@ -314,7 +314,7 @@ Usage of ./cmd/mimir/mimir: -blocks-storage.bucket-store.index-cache.memcached.max-item-size int The maximum size of an item stored in memcached. Bigger items are not stored. If set to 0, no maximum size is enforced. (default 1048576) -blocks-storage.bucket-store.index-cache.memcached.timeout duration - The socket read/write timeout. (default 100ms) + The socket read/write timeout. (default 200ms) -blocks-storage.bucket-store.index-header-lazy-loading-enabled If enabled, store-gateway will lazy load an index-header only once required by a query. (default true) -blocks-storage.bucket-store.index-header-lazy-loading-idle-timeout duration @@ -350,7 +350,7 @@ Usage of ./cmd/mimir/mimir: -blocks-storage.bucket-store.metadata-cache.memcached.max-item-size int The maximum size of an item stored in memcached. Bigger items are not stored. If set to 0, no maximum size is enforced. (default 1048576) -blocks-storage.bucket-store.metadata-cache.memcached.timeout duration - The socket read/write timeout. (default 100ms) + The socket read/write timeout. (default 200ms) -blocks-storage.bucket-store.metadata-cache.metafile-attributes-ttl duration How long to cache attributes of the block metafile. (default 168h0m0s) -blocks-storage.bucket-store.metadata-cache.metafile-content-ttl duration @@ -880,7 +880,7 @@ Usage of ./cmd/mimir/mimir: -frontend.results-cache.memcached.max-item-size int The maximum size of an item stored in memcached. Bigger items are not stored. If set to 0, no maximum size is enforced. (default 1048576) -frontend.results-cache.memcached.timeout duration - The socket read/write timeout. (default 100ms) + The socket read/write timeout. (default 200ms) -frontend.scheduler-address string DNS hostname used for finding query-schedulers. -frontend.scheduler-dns-lookup-period duration diff --git a/cmd/mimir/help.txt.tmpl b/cmd/mimir/help.txt.tmpl index 1a22a6762fc..d0b8d415629 100644 --- a/cmd/mimir/help.txt.tmpl +++ b/cmd/mimir/help.txt.tmpl @@ -122,7 +122,7 @@ Usage of ./cmd/mimir/mimir: -blocks-storage.bucket-store.chunks-cache.memcached.addresses string Comma separated list of memcached addresses. Supported prefixes are: dns+ (looked up as an A/AAAA query), dnssrv+ (looked up as a SRV query, dnssrvnoa+ (looked up as a SRV query, with no A/AAAA lookup made after that). -blocks-storage.bucket-store.chunks-cache.memcached.timeout duration - The socket read/write timeout. (default 100ms) + The socket read/write timeout. (default 200ms) -blocks-storage.bucket-store.index-cache.backend string The index cache backend type. Supported values: inmemory, memcached. (default "inmemory") -blocks-storage.bucket-store.index-cache.inmemory.max-size-bytes uint @@ -130,13 +130,13 @@ Usage of ./cmd/mimir/mimir: -blocks-storage.bucket-store.index-cache.memcached.addresses string Comma separated list of memcached addresses. Supported prefixes are: dns+ (looked up as an A/AAAA query), dnssrv+ (looked up as a SRV query, dnssrvnoa+ (looked up as a SRV query, with no A/AAAA lookup made after that). -blocks-storage.bucket-store.index-cache.memcached.timeout duration - The socket read/write timeout. (default 100ms) + The socket read/write timeout. (default 200ms) -blocks-storage.bucket-store.metadata-cache.backend string Backend for metadata cache, if not empty. Supported values: memcached. -blocks-storage.bucket-store.metadata-cache.memcached.addresses string Comma separated list of memcached addresses. Supported prefixes are: dns+ (looked up as an A/AAAA query), dnssrv+ (looked up as a SRV query, dnssrvnoa+ (looked up as a SRV query, with no A/AAAA lookup made after that). -blocks-storage.bucket-store.metadata-cache.memcached.timeout duration - The socket read/write timeout. (default 100ms) + The socket read/write timeout. (default 200ms) -blocks-storage.bucket-store.sync-dir string Directory to store synchronized TSDB index headers. (default "tsdb-sync") -blocks-storage.filesystem.dir string @@ -354,7 +354,7 @@ Usage of ./cmd/mimir/mimir: -frontend.results-cache.memcached.addresses string Comma separated list of memcached addresses. Supported prefixes are: dns+ (looked up as an A/AAAA query), dnssrv+ (looked up as a SRV query, dnssrvnoa+ (looked up as a SRV query, with no A/AAAA lookup made after that). -frontend.results-cache.memcached.timeout duration - The socket read/write timeout. (default 100ms) + The socket read/write timeout. (default 200ms) -frontend.scheduler-address string DNS hostname used for finding query-schedulers. -frontend.split-queries-by-interval duration diff --git a/docs/sources/configuration/config-file-reference.md b/docs/sources/configuration/config-file-reference.md index 1563080b258..662b089f948 100644 --- a/docs/sources/configuration/config-file-reference.md +++ b/docs/sources/configuration/config-file-reference.md @@ -3541,7 +3541,7 @@ The `memcached_config` configures the Memcached-based caching backend. The suppo # The socket read/write timeout. # CLI flag: -.memcached.timeout -[timeout: | default = 100ms] +[timeout: | default = 200ms] # [advanced] The maximum number of idle connections that will be maintained per # address. diff --git a/operations/mimir-tests/test-defaults-generated.yaml b/operations/mimir-tests/test-defaults-generated.yaml index bbef5571753..3edb8b92dd4 100644 --- a/operations/mimir-tests/test-defaults-generated.yaml +++ b/operations/mimir-tests/test-defaults-generated.yaml @@ -748,7 +748,6 @@ spec: - -blocks-storage.bucket-store.metadata-cache.memcached.addresses=dnssrvnoa+memcached-metadata.default.svc.cluster.local:11211 - -blocks-storage.bucket-store.metadata-cache.memcached.max-async-concurrency=50 - -blocks-storage.bucket-store.metadata-cache.memcached.max-item-size=1048576 - - -blocks-storage.bucket-store.metadata-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.sync-dir=/data/tsdb - -blocks-storage.gcs.bucket-name=blocks-bucket - -consul.hostname=consul.default.svc.cluster.local:8500 @@ -1314,7 +1313,6 @@ spec: - -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100 - -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=100 - -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576 - - -blocks-storage.bucket-store.chunks-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.ignore-blocks-within=10h - -blocks-storage.bucket-store.index-cache.backend=memcached - -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local:11211 @@ -1322,7 +1320,6 @@ spec: - -blocks-storage.bucket-store.index-cache.memcached.max-get-multi-concurrency=100 - -blocks-storage.bucket-store.index-cache.memcached.max-idle-connections=100 - -blocks-storage.bucket-store.index-cache.memcached.max-item-size=5242880 - - -blocks-storage.bucket-store.index-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.index-header-lazy-loading-enabled=true - -blocks-storage.bucket-store.index-header-lazy-loading-idle-timeout=60m - -blocks-storage.bucket-store.max-chunk-pool-bytes=12884901888 @@ -1332,7 +1329,6 @@ spec: - -blocks-storage.bucket-store.metadata-cache.memcached.max-get-multi-concurrency=100 - -blocks-storage.bucket-store.metadata-cache.memcached.max-idle-connections=100 - -blocks-storage.bucket-store.metadata-cache.memcached.max-item-size=1048576 - - -blocks-storage.bucket-store.metadata-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.sync-dir=/data/tsdb - -blocks-storage.gcs.bucket-name=blocks-bucket - -runtime-config.file=/etc/mimir/overrides.yaml diff --git a/operations/mimir-tests/test-disable-chunk-streaming-generated.yaml b/operations/mimir-tests/test-disable-chunk-streaming-generated.yaml index aa8f3aaf63d..f85676b273d 100644 --- a/operations/mimir-tests/test-disable-chunk-streaming-generated.yaml +++ b/operations/mimir-tests/test-disable-chunk-streaming-generated.yaml @@ -825,7 +825,6 @@ spec: - -blocks-storage.bucket-store.metadata-cache.memcached.addresses=dnssrvnoa+memcached-metadata.default.svc.cluster.local:11211 - -blocks-storage.bucket-store.metadata-cache.memcached.max-async-concurrency=50 - -blocks-storage.bucket-store.metadata-cache.memcached.max-item-size=1048576 - - -blocks-storage.bucket-store.metadata-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.sync-dir=/data/tsdb - -blocks-storage.bucket-store.sync-interval=15m - -blocks-storage.gcs.bucket-name=blocks-bucket @@ -1057,7 +1056,6 @@ spec: - -blocks-storage.bucket-store.metadata-cache.memcached.addresses=dnssrvnoa+memcached-metadata.default.svc.cluster.local:11211 - -blocks-storage.bucket-store.metadata-cache.memcached.max-async-concurrency=50 - -blocks-storage.bucket-store.metadata-cache.memcached.max-item-size=1048576 - - -blocks-storage.bucket-store.metadata-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.sync-dir=/data/tsdb - -blocks-storage.bucket-store.sync-interval=15m - -blocks-storage.gcs.bucket-name=blocks-bucket @@ -1639,7 +1637,6 @@ spec: - -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100 - -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=100 - -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576 - - -blocks-storage.bucket-store.chunks-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.ignore-blocks-within=10h - -blocks-storage.bucket-store.index-cache.backend=memcached - -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local:11211 @@ -1647,7 +1644,6 @@ spec: - -blocks-storage.bucket-store.index-cache.memcached.max-get-multi-concurrency=100 - -blocks-storage.bucket-store.index-cache.memcached.max-idle-connections=100 - -blocks-storage.bucket-store.index-cache.memcached.max-item-size=5242880 - - -blocks-storage.bucket-store.index-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.index-header-lazy-loading-enabled=true - -blocks-storage.bucket-store.index-header-lazy-loading-idle-timeout=60m - -blocks-storage.bucket-store.max-chunk-pool-bytes=12884901888 @@ -1657,7 +1653,6 @@ spec: - -blocks-storage.bucket-store.metadata-cache.memcached.max-get-multi-concurrency=100 - -blocks-storage.bucket-store.metadata-cache.memcached.max-idle-connections=100 - -blocks-storage.bucket-store.metadata-cache.memcached.max-item-size=1048576 - - -blocks-storage.bucket-store.metadata-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.sync-dir=/data/tsdb - -blocks-storage.bucket-store.sync-interval=15m - -blocks-storage.gcs.bucket-name=blocks-bucket diff --git a/operations/mimir-tests/test-query-sharding-generated.yaml b/operations/mimir-tests/test-query-sharding-generated.yaml index d2e7110bf26..3c71189b311 100644 --- a/operations/mimir-tests/test-query-sharding-generated.yaml +++ b/operations/mimir-tests/test-query-sharding-generated.yaml @@ -824,7 +824,6 @@ spec: - -blocks-storage.bucket-store.metadata-cache.memcached.addresses=dnssrvnoa+memcached-metadata.default.svc.cluster.local:11211 - -blocks-storage.bucket-store.metadata-cache.memcached.max-async-concurrency=50 - -blocks-storage.bucket-store.metadata-cache.memcached.max-item-size=1048576 - - -blocks-storage.bucket-store.metadata-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.sync-dir=/data/tsdb - -blocks-storage.bucket-store.sync-interval=15m - -blocks-storage.gcs.bucket-name=blocks-bucket @@ -1060,7 +1059,6 @@ spec: - -blocks-storage.bucket-store.metadata-cache.memcached.addresses=dnssrvnoa+memcached-metadata.default.svc.cluster.local:11211 - -blocks-storage.bucket-store.metadata-cache.memcached.max-async-concurrency=50 - -blocks-storage.bucket-store.metadata-cache.memcached.max-item-size=1048576 - - -blocks-storage.bucket-store.metadata-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.sync-dir=/data/tsdb - -blocks-storage.bucket-store.sync-interval=15m - -blocks-storage.gcs.bucket-name=blocks-bucket @@ -1642,7 +1640,6 @@ spec: - -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100 - -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=100 - -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576 - - -blocks-storage.bucket-store.chunks-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.ignore-blocks-within=10h - -blocks-storage.bucket-store.index-cache.backend=memcached - -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local:11211 @@ -1650,7 +1647,6 @@ spec: - -blocks-storage.bucket-store.index-cache.memcached.max-get-multi-concurrency=100 - -blocks-storage.bucket-store.index-cache.memcached.max-idle-connections=100 - -blocks-storage.bucket-store.index-cache.memcached.max-item-size=5242880 - - -blocks-storage.bucket-store.index-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.index-header-lazy-loading-enabled=true - -blocks-storage.bucket-store.index-header-lazy-loading-idle-timeout=60m - -blocks-storage.bucket-store.max-chunk-pool-bytes=12884901888 @@ -1660,7 +1656,6 @@ spec: - -blocks-storage.bucket-store.metadata-cache.memcached.max-get-multi-concurrency=100 - -blocks-storage.bucket-store.metadata-cache.memcached.max-idle-connections=100 - -blocks-storage.bucket-store.metadata-cache.memcached.max-item-size=1048576 - - -blocks-storage.bucket-store.metadata-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.sync-dir=/data/tsdb - -blocks-storage.bucket-store.sync-interval=15m - -blocks-storage.gcs.bucket-name=blocks-bucket diff --git a/operations/mimir-tests/test-shuffle-sharding-generated.yaml b/operations/mimir-tests/test-shuffle-sharding-generated.yaml index 3620125b47a..c6e931f444b 100644 --- a/operations/mimir-tests/test-shuffle-sharding-generated.yaml +++ b/operations/mimir-tests/test-shuffle-sharding-generated.yaml @@ -825,7 +825,6 @@ spec: - -blocks-storage.bucket-store.metadata-cache.memcached.addresses=dnssrvnoa+memcached-metadata.default.svc.cluster.local:11211 - -blocks-storage.bucket-store.metadata-cache.memcached.max-async-concurrency=50 - -blocks-storage.bucket-store.metadata-cache.memcached.max-item-size=1048576 - - -blocks-storage.bucket-store.metadata-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.sync-dir=/data/tsdb - -blocks-storage.bucket-store.sync-interval=15m - -blocks-storage.gcs.bucket-name=blocks-bucket @@ -1062,7 +1061,6 @@ spec: - -blocks-storage.bucket-store.metadata-cache.memcached.addresses=dnssrvnoa+memcached-metadata.default.svc.cluster.local:11211 - -blocks-storage.bucket-store.metadata-cache.memcached.max-async-concurrency=50 - -blocks-storage.bucket-store.metadata-cache.memcached.max-item-size=1048576 - - -blocks-storage.bucket-store.metadata-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.sync-dir=/data/tsdb - -blocks-storage.bucket-store.sync-interval=15m - -blocks-storage.gcs.bucket-name=blocks-bucket @@ -1649,7 +1647,6 @@ spec: - -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100 - -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=100 - -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576 - - -blocks-storage.bucket-store.chunks-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.ignore-blocks-within=10h - -blocks-storage.bucket-store.index-cache.backend=memcached - -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local:11211 @@ -1657,7 +1654,6 @@ spec: - -blocks-storage.bucket-store.index-cache.memcached.max-get-multi-concurrency=100 - -blocks-storage.bucket-store.index-cache.memcached.max-idle-connections=100 - -blocks-storage.bucket-store.index-cache.memcached.max-item-size=5242880 - - -blocks-storage.bucket-store.index-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.index-header-lazy-loading-enabled=true - -blocks-storage.bucket-store.index-header-lazy-loading-idle-timeout=60m - -blocks-storage.bucket-store.max-chunk-pool-bytes=12884901888 @@ -1667,7 +1663,6 @@ spec: - -blocks-storage.bucket-store.metadata-cache.memcached.max-get-multi-concurrency=100 - -blocks-storage.bucket-store.metadata-cache.memcached.max-idle-connections=100 - -blocks-storage.bucket-store.metadata-cache.memcached.max-item-size=1048576 - - -blocks-storage.bucket-store.metadata-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.sync-dir=/data/tsdb - -blocks-storage.bucket-store.sync-interval=15m - -blocks-storage.gcs.bucket-name=blocks-bucket diff --git a/operations/mimir-tests/test-storage-azure-generated.yaml b/operations/mimir-tests/test-storage-azure-generated.yaml index 70408e4f18e..84a4f8e5524 100644 --- a/operations/mimir-tests/test-storage-azure-generated.yaml +++ b/operations/mimir-tests/test-storage-azure-generated.yaml @@ -827,7 +827,6 @@ spec: - -blocks-storage.bucket-store.metadata-cache.memcached.addresses=dnssrvnoa+memcached-metadata.default.svc.cluster.local:11211 - -blocks-storage.bucket-store.metadata-cache.memcached.max-async-concurrency=50 - -blocks-storage.bucket-store.metadata-cache.memcached.max-item-size=1048576 - - -blocks-storage.bucket-store.metadata-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.sync-dir=/data/tsdb - -blocks-storage.bucket-store.sync-interval=15m - -consul.hostname=consul.default.svc.cluster.local:8500 @@ -1061,7 +1060,6 @@ spec: - -blocks-storage.bucket-store.metadata-cache.memcached.addresses=dnssrvnoa+memcached-metadata.default.svc.cluster.local:11211 - -blocks-storage.bucket-store.metadata-cache.memcached.max-async-concurrency=50 - -blocks-storage.bucket-store.metadata-cache.memcached.max-item-size=1048576 - - -blocks-storage.bucket-store.metadata-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.sync-dir=/data/tsdb - -blocks-storage.bucket-store.sync-interval=15m - -consul.hostname=consul.default.svc.cluster.local:8500 @@ -1653,7 +1651,6 @@ spec: - -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100 - -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=100 - -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576 - - -blocks-storage.bucket-store.chunks-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.ignore-blocks-within=10h - -blocks-storage.bucket-store.index-cache.backend=memcached - -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local:11211 @@ -1661,7 +1658,6 @@ spec: - -blocks-storage.bucket-store.index-cache.memcached.max-get-multi-concurrency=100 - -blocks-storage.bucket-store.index-cache.memcached.max-idle-connections=100 - -blocks-storage.bucket-store.index-cache.memcached.max-item-size=5242880 - - -blocks-storage.bucket-store.index-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.index-header-lazy-loading-enabled=true - -blocks-storage.bucket-store.index-header-lazy-loading-idle-timeout=60m - -blocks-storage.bucket-store.max-chunk-pool-bytes=12884901888 @@ -1671,7 +1667,6 @@ spec: - -blocks-storage.bucket-store.metadata-cache.memcached.max-get-multi-concurrency=100 - -blocks-storage.bucket-store.metadata-cache.memcached.max-idle-connections=100 - -blocks-storage.bucket-store.metadata-cache.memcached.max-item-size=1048576 - - -blocks-storage.bucket-store.metadata-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.sync-dir=/data/tsdb - -blocks-storage.bucket-store.sync-interval=15m - -runtime-config.file=/etc/mimir/overrides.yaml diff --git a/operations/mimir-tests/test-storage-gcs-generated.yaml b/operations/mimir-tests/test-storage-gcs-generated.yaml index 42ef58d0232..522837bc260 100644 --- a/operations/mimir-tests/test-storage-gcs-generated.yaml +++ b/operations/mimir-tests/test-storage-gcs-generated.yaml @@ -824,7 +824,6 @@ spec: - -blocks-storage.bucket-store.metadata-cache.memcached.addresses=dnssrvnoa+memcached-metadata.default.svc.cluster.local:11211 - -blocks-storage.bucket-store.metadata-cache.memcached.max-async-concurrency=50 - -blocks-storage.bucket-store.metadata-cache.memcached.max-item-size=1048576 - - -blocks-storage.bucket-store.metadata-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.sync-dir=/data/tsdb - -blocks-storage.bucket-store.sync-interval=15m - -blocks-storage.gcs.bucket-name=blocks-bucket @@ -1056,7 +1055,6 @@ spec: - -blocks-storage.bucket-store.metadata-cache.memcached.addresses=dnssrvnoa+memcached-metadata.default.svc.cluster.local:11211 - -blocks-storage.bucket-store.metadata-cache.memcached.max-async-concurrency=50 - -blocks-storage.bucket-store.metadata-cache.memcached.max-item-size=1048576 - - -blocks-storage.bucket-store.metadata-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.sync-dir=/data/tsdb - -blocks-storage.bucket-store.sync-interval=15m - -blocks-storage.gcs.bucket-name=blocks-bucket @@ -1638,7 +1636,6 @@ spec: - -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100 - -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=100 - -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576 - - -blocks-storage.bucket-store.chunks-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.ignore-blocks-within=10h - -blocks-storage.bucket-store.index-cache.backend=memcached - -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local:11211 @@ -1646,7 +1643,6 @@ spec: - -blocks-storage.bucket-store.index-cache.memcached.max-get-multi-concurrency=100 - -blocks-storage.bucket-store.index-cache.memcached.max-idle-connections=100 - -blocks-storage.bucket-store.index-cache.memcached.max-item-size=5242880 - - -blocks-storage.bucket-store.index-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.index-header-lazy-loading-enabled=true - -blocks-storage.bucket-store.index-header-lazy-loading-idle-timeout=60m - -blocks-storage.bucket-store.max-chunk-pool-bytes=12884901888 @@ -1656,7 +1652,6 @@ spec: - -blocks-storage.bucket-store.metadata-cache.memcached.max-get-multi-concurrency=100 - -blocks-storage.bucket-store.metadata-cache.memcached.max-idle-connections=100 - -blocks-storage.bucket-store.metadata-cache.memcached.max-item-size=1048576 - - -blocks-storage.bucket-store.metadata-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.sync-dir=/data/tsdb - -blocks-storage.bucket-store.sync-interval=15m - -blocks-storage.gcs.bucket-name=blocks-bucket diff --git a/operations/mimir-tests/test-storage-s3-generated.yaml b/operations/mimir-tests/test-storage-s3-generated.yaml index 9bf79ed084a..6ad2a732c47 100644 --- a/operations/mimir-tests/test-storage-s3-generated.yaml +++ b/operations/mimir-tests/test-storage-s3-generated.yaml @@ -824,7 +824,6 @@ spec: - -blocks-storage.bucket-store.metadata-cache.memcached.addresses=dnssrvnoa+memcached-metadata.default.svc.cluster.local:11211 - -blocks-storage.bucket-store.metadata-cache.memcached.max-async-concurrency=50 - -blocks-storage.bucket-store.metadata-cache.memcached.max-item-size=1048576 - - -blocks-storage.bucket-store.metadata-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.sync-dir=/data/tsdb - -blocks-storage.bucket-store.sync-interval=15m - -blocks-storage.s3.bucket-name=blocks-bucket @@ -1057,7 +1056,6 @@ spec: - -blocks-storage.bucket-store.metadata-cache.memcached.addresses=dnssrvnoa+memcached-metadata.default.svc.cluster.local:11211 - -blocks-storage.bucket-store.metadata-cache.memcached.max-async-concurrency=50 - -blocks-storage.bucket-store.metadata-cache.memcached.max-item-size=1048576 - - -blocks-storage.bucket-store.metadata-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.sync-dir=/data/tsdb - -blocks-storage.bucket-store.sync-interval=15m - -blocks-storage.s3.bucket-name=blocks-bucket @@ -1645,7 +1643,6 @@ spec: - -blocks-storage.bucket-store.chunks-cache.memcached.max-get-multi-concurrency=100 - -blocks-storage.bucket-store.chunks-cache.memcached.max-idle-connections=100 - -blocks-storage.bucket-store.chunks-cache.memcached.max-item-size=1048576 - - -blocks-storage.bucket-store.chunks-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.ignore-blocks-within=10h - -blocks-storage.bucket-store.index-cache.backend=memcached - -blocks-storage.bucket-store.index-cache.memcached.addresses=dnssrvnoa+memcached-index-queries.default.svc.cluster.local:11211 @@ -1653,7 +1650,6 @@ spec: - -blocks-storage.bucket-store.index-cache.memcached.max-get-multi-concurrency=100 - -blocks-storage.bucket-store.index-cache.memcached.max-idle-connections=100 - -blocks-storage.bucket-store.index-cache.memcached.max-item-size=5242880 - - -blocks-storage.bucket-store.index-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.index-header-lazy-loading-enabled=true - -blocks-storage.bucket-store.index-header-lazy-loading-idle-timeout=60m - -blocks-storage.bucket-store.max-chunk-pool-bytes=12884901888 @@ -1663,7 +1659,6 @@ spec: - -blocks-storage.bucket-store.metadata-cache.memcached.max-get-multi-concurrency=100 - -blocks-storage.bucket-store.metadata-cache.memcached.max-idle-connections=100 - -blocks-storage.bucket-store.metadata-cache.memcached.max-item-size=1048576 - - -blocks-storage.bucket-store.metadata-cache.memcached.timeout=200ms - -blocks-storage.bucket-store.sync-dir=/data/tsdb - -blocks-storage.bucket-store.sync-interval=15m - -blocks-storage.s3.bucket-name=blocks-bucket diff --git a/operations/mimir/config.libsonnet b/operations/mimir/config.libsonnet index 5b802667537..cf16d1f077d 100644 --- a/operations/mimir/config.libsonnet +++ b/operations/mimir/config.libsonnet @@ -405,7 +405,6 @@ if $._config.memcached_index_queries_enabled then { 'blocks-storage.bucket-store.index-cache.backend': 'memcached', 'blocks-storage.bucket-store.index-cache.memcached.addresses': 'dnssrvnoa+memcached-index-queries.%(namespace)s.svc.cluster.local:11211' % $._config, - 'blocks-storage.bucket-store.index-cache.memcached.timeout': '200ms', 'blocks-storage.bucket-store.index-cache.memcached.max-item-size': $._config.memcached_index_queries_max_item_size_mb * 1024 * 1024, 'blocks-storage.bucket-store.index-cache.memcached.max-async-concurrency': '50', } else {} @@ -413,7 +412,6 @@ if $._config.memcached_chunks_enabled then { 'blocks-storage.bucket-store.chunks-cache.backend': 'memcached', 'blocks-storage.bucket-store.chunks-cache.memcached.addresses': 'dnssrvnoa+memcached.%(namespace)s.svc.cluster.local:11211' % $._config, - 'blocks-storage.bucket-store.chunks-cache.memcached.timeout': '200ms', 'blocks-storage.bucket-store.chunks-cache.memcached.max-item-size': $._config.memcached_chunks_max_item_size_mb * 1024 * 1024, 'blocks-storage.bucket-store.chunks-cache.memcached.max-async-concurrency': '50', } else {} @@ -422,7 +420,6 @@ blocks_metadata_caching_config:: if $._config.memcached_metadata_enabled then { 'blocks-storage.bucket-store.metadata-cache.backend': 'memcached', 'blocks-storage.bucket-store.metadata-cache.memcached.addresses': 'dnssrvnoa+memcached-metadata.%(namespace)s.svc.cluster.local:11211' % $._config, - 'blocks-storage.bucket-store.metadata-cache.memcached.timeout': '200ms', 'blocks-storage.bucket-store.metadata-cache.memcached.max-item-size': $._config.memcached_metadata_max_item_size_mb * 1024 * 1024, 'blocks-storage.bucket-store.metadata-cache.memcached.max-async-concurrency': '50', } else {}, diff --git a/pkg/cache/memcache_config.go b/pkg/cache/memcache_config.go index 3b922a369fa..893b2a90b58 100644 --- a/pkg/cache/memcache_config.go +++ b/pkg/cache/memcache_config.go @@ -32,7 +32,7 @@ type MemcachedConfig struct { func (cfg *MemcachedConfig) RegisterFlagsWithPrefix(f *flag.FlagSet, prefix string) { f.StringVar(&cfg.Addresses, prefix+"addresses", "", "Comma separated list of memcached addresses. Supported prefixes are: dns+ (looked up as an A/AAAA query), dnssrv+ (looked up as a SRV query, dnssrvnoa+ (looked up as a SRV query, with no A/AAAA lookup made after that).") - f.DurationVar(&cfg.Timeout, prefix+"timeout", 100*time.Millisecond, "The socket read/write timeout.") + f.DurationVar(&cfg.Timeout, prefix+"timeout", 200*time.Millisecond, "The socket read/write timeout.") f.IntVar(&cfg.MaxIdleConnections, prefix+"max-idle-connections", 100, "The maximum number of idle connections that will be maintained per address.") f.IntVar(&cfg.MaxAsyncConcurrency, prefix+"max-async-concurrency", 50, "The maximum number of concurrent asynchronous operations can occur.") f.IntVar(&cfg.MaxAsyncBufferSize, prefix+"max-async-buffer-size", 25000, "The maximum number of enqueued asynchronous operations allowed.")