Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sharding strategy options #857

Closed
Tracked by #827
pstibrany opened this issue Jan 24, 2022 · 3 comments
Closed
Tracked by #827

Remove sharding strategy options #857

pstibrany opened this issue Jan 24, 2022 · 3 comments
Assignees

Comments

@pstibrany
Copy link
Member

pstibrany commented Jan 24, 2022

Components that use ring for sharding often have option to use two different sharding strategies: "default" and "shuffle-sharding".

I propose to drop support for "default" strategy in the configuration and code. When using shuffle sharding, it is easy to get the effect of "default" strategy simply by setting shard size of the tenant to 0.

This affects:

  • distributor
  • ruler
  • compactor
  • store-gateway

Benefit of this change is small reduction of CLI parameters, code and documentation.

@pracucci
Copy link
Collaborator

I propose to drop support for "default" strategy in the configuration and code. When using shuffle sharding, it is easy to get the effect of "default" strategy simply by setting shard size of the tenant to 0.

I agree. I would also make sure default shard size is 0.

@09jvilla
Copy link
Contributor

Renaming to remove 'proposal' since we're going to move forward with this based on the thumbs up / feedback from others on this issue.

@pstibrany
Copy link
Member Author

This is finished, changes were done in #888, #889, #891 and #903.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants