-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sharding strategy options #857
Comments
I agree. I would also make sure default shard size is 0. |
Renaming to remove 'proposal' since we're going to move forward with this based on the thumbs up / feedback from others on this issue. |
09jvilla
changed the title
Proposal: remove sharding strategy options
Remove sharding strategy options
Jan 25, 2022
This was referenced Jan 25, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Components that use ring for sharding often have option to use two different sharding strategies: "default" and "shuffle-sharding".
I propose to drop support for "default" strategy in the configuration and code. When using shuffle sharding, it is easy to get the effect of "default" strategy simply by setting shard size of the tenant to 0.
This affects:
compactorBenefit of this change is small reduction of CLI parameters, code and documentation.
The text was updated successfully, but these errors were encountered: