Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test field classification overrides #1164

Closed
andyasp opened this issue Feb 10, 2022 · 0 comments · Fixed by #1210
Closed

Test field classification overrides #1164

andyasp opened this issue Feb 10, 2022 · 0 comments · Fixed by #1210
Assignees
@andyasp
Labels
type/docs Improvements or additions to documentation type/tests

Comments

@andyasp
Copy link
Contributor

andyasp commented Feb 10, 2022

Field classification is typically done in struct tags, but some fields can't be classified that way. #1125 introduced an override mechanism as a workaround, but there should be a test to ensure the overrides don't become stale.

Context: #1125 (comment)
@andyasp andyasp self-assigned this Feb 10, 2022
@andyasp andyasp mentioned this issue Feb 10, 2022
Merged
3 tasks
@andyasp andyasp added type/docs Improvements or additions to documentation type/tests labels Feb 10, 2022
@andyasp andyasp mentioned this issue Feb 16, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andyasp andyasp

Labels
type/docs Improvements or additions to documentation type/tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add test for stale field category overrides grafana/mimir
1 participant
@andyasp