diff --git a/pkg/ingester/ingester.go b/pkg/ingester/ingester.go index 89a61d91483..1c6b97d3bd5 100644 --- a/pkg/ingester/ingester.go +++ b/pkg/ingester/ingester.go @@ -1137,8 +1137,6 @@ func (i *Ingester) pushSamplesToAppender(userID string, timeseries []mimirpb.Pre return wrapWithUser(err, userID) } - } else { // ignore histograms and increase counter - stats.histogramStats.failedSamplesCount++ } } diff --git a/pkg/ingester/ingester_test.go b/pkg/ingester/ingester_test.go index fec292ad941..c4e0ab66e90 100644 --- a/pkg/ingester/ingester_test.go +++ b/pkg/ingester/ingester_test.go @@ -482,9 +482,6 @@ func TestIngester_Push(t *testing.T) { # HELP cortex_ingester_ingested_samples_total The total number of samples ingested per user. # TYPE cortex_ingester_ingested_samples_total counter cortex_ingester_ingested_samples_total{user="test"} 2 - # HELP cortex_ingester_ingested_samples_failures_total The total number of samples that errored on ingestion per user. - # TYPE cortex_ingester_ingested_samples_failures_total counter - cortex_ingester_ingested_samples_failures_total{user="test"} 1 # HELP cortex_ingester_memory_users The current number of users in memory. # TYPE cortex_ingester_memory_users gauge cortex_ingester_memory_users 1 @@ -7383,9 +7380,6 @@ func testIngesterCanEnableIngestAndQueryNativeHistograms(t *testing.T, sampleHis require.NoError(t, err) expectedMetrics := ` - # HELP cortex_ingester_ingested_samples_failures_total The total number of samples that errored on ingestion per user. - # TYPE cortex_ingester_ingested_samples_failures_total counter - cortex_ingester_ingested_samples_failures_total{user="1"} 1 # HELP cortex_ingester_ingested_samples_total The total number of samples ingested per user. # TYPE cortex_ingester_ingested_samples_total counter cortex_ingester_ingested_samples_total{user="1"} 1 @@ -7435,9 +7429,6 @@ func testIngesterCanEnableIngestAndQueryNativeHistograms(t *testing.T, sampleHis require.NoError(t, err) expectedMetrics = ` - # HELP cortex_ingester_ingested_samples_failures_total The total number of samples that errored on ingestion per user. - # TYPE cortex_ingester_ingested_samples_failures_total counter - cortex_ingester_ingested_samples_failures_total{user="1"} 1 # HELP cortex_ingester_ingested_samples_total The total number of samples ingested per user. # TYPE cortex_ingester_ingested_samples_total counter cortex_ingester_ingested_samples_total{user="1"} 2