fix(operator): Fix RBAC permission for poddisruptionbudgets #15107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xperimental
requested review from
periklis,
JoaoBraveCoding and
a team
as code owners
|
I'm merging this since the warning referenced in #14817 (k8s-operatorhub/community-operators#5249 (comment)) are being generated by operator-sdk (https://github.com/k8s-operatorhub/community-operators/actions/runs/11720622623/job/32646420918#step:6:1275) which doesn't check for the version of the deprecated API see https://github.com/operator-framework/api/blob/master/pkg/validation/internal/removed_apis.go#L306 Created issue in validation tool operator-framework/api#378 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR fixes an RBAC issue accidentally introduced by #14817. The current permission references
policy/v1as an API group which is not valid (groups do not contain a version).The current state causes the operator to stop working once it tries to interact with PodDisruptionBudget resources, because it can not recover from the error returned by the API.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)