Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [k211] fix: add a retry middleware to all the stats handlers #13590

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

grafanabot
Copy link
Collaborator

Backport 7232795 from #13584


What this PR does / why we need it:

We use retry middleware for all the subquery downstream requests through the scheduler to the querier, but we did not have any retries on our stats calls which also go through the schedulers downstream to the queriers, this leads to a number of 5xx errors on queries which very likely would have been resolved by a simple retry.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

Signed-off-by: Edward Welch <[email protected]>
(cherry picked from commit 7232795)
@slim-bean slim-bean merged commit 1d0a77d into k211 Jul 19, 2024
35 of 36 checks passed
@slim-bean slim-bean deleted the backport-13584-to-k211 branch July 19, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants