perf: Gather aggregate per-line and per-tenant metrics for Drain patterns #13368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
reviewed
Jul 1, 2024
pkg/pattern/drain/metrics.go
Outdated
| return FormatUnknown | ||
| } else if line[0] == '{' && line[len(line)-1] == '}' { | ||
| return FormatJson | ||
| } else if strings.Count(line, "=") > strings.Count(line, " ")-5 { |
There was a problem hiding this comment.
Honestly, that number is what worked against our testdata! I think this is slightly better than only checking if the string contains an =.
If you feel strongly about making this more robust, I can rewrite it as a regex. Its only used once per stream so that shouldn't be a problem, performance wise.
There was a problem hiding this comment.
I think we need something a bit more robust. There could be a lot of spaces in multiple fields ?
This was referenced Jul 8, 2024
This was referenced Aug 15, 2024
This was referenced Oct 14, 2024
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds metrics to help us understand what Drain is doing & to understand the shape of our log lines. These should better direct our efforts at improving pattern detection.