-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: All lifecycler cfgs ref a valid IPv6 addr and port combination #11121
Conversation
Hello @periklis!
Please, if the current pull request addresses a bug fix, label it with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
…11121) **What this PR does / why we need it**: Ensure that all constructors of LifeCyclerConfig are using `net.JoinHostPort` for instance addr and port combinations. This enables IPv6 usage compatible across the code based. Currently only distributors provide IPv6 compatibility because they use `Lifecycler` (that pulls the addr/port in the `NewLifeCycler`) while everything else uses `BasicLifeCycler` delegate this to the user defining an addr/port combination in `LifecyclerConfig`. (cherry picked from commit 6385b19)
…rt combination (#11144) Backport 6385b19 from #11121 Co-authored-by: Periklis Tsirakidis <[email protected]>
…rafana#11121) **What this PR does / why we need it**: Ensure that all constructors of LifeCyclerConfig are using `net.JoinHostPort` for instance addr and port combinations. This enables IPv6 usage compatible across the code based. Currently only distributors provide IPv6 compatibility because they use `Lifecycler` (that pulls the addr/port in the `NewLifeCycler`) while everything else uses `BasicLifeCycler` delegate this to the user defining an addr/port combination in `LifecyclerConfig`.
What this PR does / why we need it:
Ensure that all constructors of LifeCyclerConfig are using
net.JoinHostPort
for instance addr and port combinations. This enables IPv6 usage compatible across the code based. Currently only distributors provide IPv6 compatibility because they useLifecycler
(that pulls the addr/port in theNewLifeCycler
) while everything else usesBasicLifeCycler
delegate this to the user defining an addr/port combination inLifecyclerConfig
.Which issue(s) this PR fixes:
Fixes #10884
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updatedadd-to-release-notes
labeldocs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR