Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loki-mixin: Expose prometheus rules as prometheusRules instead of prometheus_rules #679

Closed
sandhose opened this issue Jun 18, 2019 · 0 comments · Fixed by #691
Closed

loki-mixin: Expose prometheus rules as prometheusRules instead of prometheus_rules #679

sandhose opened this issue Jun 18, 2019 · 0 comments · Fixed by #691

Comments

@sandhose
Copy link

The Prometheus rules defined in the mixin are under the prometheus_rules key. There's a design document that define how monitoring mixins should work, and it says prometheus rules should live under the prometheusRules key.

diff --git a/production/loki-mixin/recording_rules.libsonnet b/production/loki-mixin/recording_rules.libsonnet
index 7bf1f40..c4f121c 100644
--- a/production/loki-mixin/recording_rules.libsonnet
+++ b/production/loki-mixin/recording_rules.libsonnet
@@ -1,7 +1,7 @@
 local utils = import "mixin-utils/utils.libsonnet";
 
 {
-  prometheus_rules+:: {
+  prometheusRules+:: {
     groups+: [{
       name: 'loki_rules',
       rules:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants