Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make configuration name consistent #5703

Closed
franzwong opened this issue Mar 23, 2022 · 1 comment · Fixed by #5707
Closed

Make configuration name consistent #5703

franzwong opened this issue Mar 23, 2022 · 1 comment · Fixed by #5707
Labels
component/promtail type/enhancement Something existing could be improved

Comments

@franzwong
Copy link
Contributor

Is your feature request related to a problem? Please describe.
PR #5031 introduces limit_config for promtail config. But we already have limits_config (with an "s") for loki config.

Describe the solution you'd like
If that PR is not released, we should change the promtail config name to limits_config

Describe alternatives you've considered
None

Additional context
None
@kavirajk
Copy link
Contributor

Good point @franzwong. Do you mind sending a PR to make the config consistent with name (limits_config)?

@kavirajk kavirajk added type/enhancement Something existing could be improved component/promtail labels Mar 23, 2022
@franzwong franzwong mentioned this issue Mar 24, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/promtail type/enhancement Something existing could be improved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Promtail: Rename config name limit_config to limits_config
2 participants
@franzwong @kavirajk