You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Currently Loki configs file are not superseded by command line flags except for limits but limit
cannot be partially provided and fulfilled by default.
Describe the solution you'd like
Viper from https://github.com/spf13/viper could allow us to have correct order of config precedence with extra features like sane defaults and config reload. This should be fine to integrate even if cortex uses golang flag, viper support also it.
Is your feature request related to a problem? Please describe.
Currently Loki configs file are not superseded by command line flags except for limits but limit
cannot be partially provided and fulfilled by default.
Describe the solution you'd like
Viper from https://github.com/spf13/viper could allow us to have correct order of config precedence with extra features like sane defaults and config reload. This should be fine to integrate even if cortex uses golang flag, viper support also it.
Additional context
#519
#518
https://github.com/cortexproject/cortex/blob/master/pkg/util/validation/limits.go#L65-L73
The text was updated successfully, but these errors were encountered: