You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Expected behavior
When a block is not provided in yaml, I would expect the defaults to be used. It looks like the way we refactored parsing the default configs when introducing the dynamic config section for the common config work, that we broke this behavior, and that zero values from the yaml are being preferred over defaults.
The text was updated successfully, but these errors were encountered:
This turns out to be a red herring. This behavior only happens when a completely empty file is used as the config file, ie:
---
I was using that as test input which was causing the oddities, but as this is unexpected use case I don't think it needs special handling, nor do I think loki will even start if given a config like this.
Describe the bug
When parsing config files, zero values resulting from the yaml unmarshalling are taking precedence over defaults.
To Reproduce
Steps to reproduce the behavior:
server
stanzaExpected behavior
When a block is not provided in yaml, I would expect the defaults to be used. It looks like the way we refactored parsing the default configs when introducing the dynamic config section for the common config work, that we broke this behavior, and that zero values from the yaml are being preferred over defaults.
The text was updated successfully, but these errors were encountered: