Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimize label hashing in metric queries #1672

Closed
owen-d opened this issue Feb 11, 2020 · 2 comments
Closed

Minimize label hashing in metric queries #1672

owen-d opened this issue Feb 11, 2020 · 2 comments
Labels
component/loki keepalive An issue or PR that will be kept alive and never marked as stale. type/enhancement Something existing could be improved

Comments

@owen-d
Copy link
Member

owen-d commented Feb 11, 2020 •
edited
Loading

When calculating metric queries, we hash labels per each step and sample due to the StepEvaluator construct. We should look to minimize this, possibly by changing our StepEvaluator interface/implementers, using a shared LRU cache, etc.

Any work here will probably follow #1662
@owen-d owen-d mentioned this issue Feb 11, 2020
Merged
@owen-d
Copy link
Member Author

owen-d commented Feb 12, 2020

/cc @cyriltovena

@cyriltovena cyriltovena added component/loki type/enhancement Something existing could be improved keepalive An issue or PR that will be kept alive and never marked as stale. labels Feb 12, 2020
@slim-bean
Copy link
Collaborator

This has been improved since the issue was originally opened and doesn't appear to still be the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/loki keepalive An issue or PR that will be kept alive and never marked as stale. type/enhancement Something existing could be improved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cyriltovena @owen-d @slim-bean