Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(operator)!: Rename loki api go module #14568

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

periklis
Copy link
Collaborator

What this PR does / why we need it:
Renames the loki API module github.com/grafana/loki/operator/apis/loki to github.com/grafana/loki/operator/api/loki based on the migration changes from kubebuilder project layout go/v3 to go/v4/.

Follow up on:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

Copy link
Collaborator

@xperimental xperimental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still references to the old path in config/docs/config.json. It does not seem to change anything in docs/operator/api.md or docs/operator/feature-gates.md when I change it and regenerate, so I'm not sure if this file is used / where it's used.

@periklis periklis merged commit 976d8ab into grafana:main Oct 22, 2024
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants