feat: Ingester RF-1 #13365
Merged
feat: Ingester RF-1 #13365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type/docs
This commit is a work-in-progress of Ingester RF-1 (replication factor = 1). It is disabled by default.
grobinson-grafana
force-pushed
the
grobinson/ingester-rf1
branch
from
2afad46
to
64306a0
Compare
cyriltovena
reviewed
Jul 3, 2024
| @@ -159,7 +163,9 @@ func (c *Config) RegisterFlags(f *flag.FlagSet) { | |||
| c.CompactorHTTPClient.RegisterFlags(f) | |||
| c.CompactorGRPCClient.RegisterFlags(f) | |||
| c.IngesterClient.RegisterFlags(f) | |||
| //c.IngesterRF1Client.RegisterFlags(f) | |||
There was a problem hiding this comment.
Suggested change
| //c.IngesterRF1Client.RegisterFlags(f) | |
| //c.IngesterRF1Client.RegisterFlags(f) |
cyriltovena
reviewed
Jul 3, 2024
cyriltovena
approved these changes
Jul 3, 2024
benclive
approved these changes
Jul 3, 2024
benclive
reviewed
Jul 3, 2024
pkg/ingester-rf1/ingester.go
Outdated
| case <-i.loopQuit: | ||
| return | ||
| } | ||
| } | ||
| } | ||
|
|
||
| func (i *Ingester) doFlushTick() { | ||
| i.flushCtx.lock.Lock() | ||
| defer i.flushCtx.lock.Unlock() |
There was a problem hiding this comment.
This probably doesn't hurt but we actually don't want to unlock this - the context is only locked once when its no longer accepting writes.
I wonder if its possible that this goroutine can gets pre-empted and another tick can fire before we swap in a new context? In that case we'd block the timer thread completely waiting on the lock... Best to leave the unlock here for now in that case!
There was a problem hiding this comment.
I think you are right!
benclive
approved these changes
Jul 3, 2024
benclive
approved these changes
Jul 3, 2024
This was referenced Jul 8, 2024
This was referenced Aug 15, 2024
This was referenced Oct 14, 2024
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This pull request starts a work-in-progress of Ingester RF-1 (replication factor = 1). It is disabled by default.
Co-authored by @benclive and @grobinson-grafana.
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR