Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.4.0] Unrecognized storage client dynamodb #1281

Closed
Tzrlk opened this issue Nov 19, 2019 · 1 comment · Fixed by #1974
Closed

[v0.4.0] Unrecognized storage client dynamodb #1281

Tzrlk opened this issue Nov 19, 2019 · 1 comment · Fixed by #1974
Labels
keepalive An issue or PR that will be kept alive and never marked as stale.

Comments

@Tzrlk
Copy link

Tzrlk commented Nov 19, 2019

Describe the bug
When following the configuration reference, the comment above schema_config.configs[*].store says:

# Which store to use for the index. Either cassandra, bigtable, dynamodb, or
# boltdb
store: <string>

However, when running loki with dynamodb as the client, the following message is sent to the logs:

level=error ts=2019-11-19T00:52:11.372697769Z caller=main.go:65 msg="error initialising loki" err="error initialising module: table-manager: Unrecognized storage client dynamodb, choose one of: aws, cassandra, inmemory, gcp, bigtable, bigtable-hashed"

To Reproduce
Steps to reproduce the behavior:

  1. In an aws dynamodb-backed deployment, set the schema config store type to dynamodb as per the documentation.

Expected behavior
Starting up and using the dynamodb config was expected.

Environment:

  • Infrastructure: Kubernetes, EKS, AWS
  • Deployment tool: Helm

Screenshots, Promtail config, or terminal output
image

@slim-bean
Copy link
Collaborator

Hey @Tzrlk, it looks like that comment is wrong :(

https://github.com/cortexproject/cortex/blob/ed7c302fd96892b1c4c822a6ccd60317fde51c00/pkg/chunk/storage/factory.go#L182

Looks like you would need to use aws

This is confusing, will leave this issue open to see if we can tidy this up some.

@slim-bean slim-bean added the keepalive An issue or PR that will be kept alive and never marked as stale. label Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keepalive An issue or PR that will be kept alive and never marked as stale.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants