Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change /loki/api/v1/push JSON object to be consistent with other v1 paths #1142

Closed
rfratto opened this issue Oct 11, 2019 · 0 comments · Fixed by #1145
Closed

Change /loki/api/v1/push JSON object to be consistent with other v1 paths #1142

rfratto opened this issue Oct 11, 2019 · 0 comments · Fixed by #1145
Assignees
Labels
component/loki type/enhancement Something existing could be improved

Comments

@rfratto
Copy link
Member

rfratto commented Oct 11, 2019

In the API docs for the push path, the POST body still accepts a single string to refer to all of the labels (i.e., "{foo=\"bar\"}").

This way of referring to the label set has deprecated in all other v1 endpoints, replaced with a labels object: {"foo": "bar"}. Before 0.4.0 is released with the new endpoints, it would be good to change the push endpoint to make it consistent with the other ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/loki type/enhancement Something existing could be improved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants