Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slow delivery might block message buffering #10

Open
samber opened this issue Jul 29, 2024 · 0 comments
Open

Slow delivery might block message buffering #10

samber opened this issue Jul 29, 2024 · 0 comments

Comments

@samber
Copy link

samber commented Jul 29, 2024 •
edited
Loading

In client.go, flushing the buffer to the log sink can be very slow, depending on network congestion and latency.

During that time, the unbuffered channel c.entries will block the main process from emitting log.

I think sendBatch should be called in a goroutine, except for final flush.

Linking the issue to samber/slog-loki#18 and samber/slog-loki#19

WDYT ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samber