metrics.extraMetricRelabelingRules doesn't work anymore

[jkleinlercher]

After the changes in #992 in line

k8s-monitoring-helm/charts/k8s-monitoring-v1/templates/alloy_config/_operator_objects.txt

Line 29 in ddc20ba

{{- if or $metricAllowList $metricDenyList .Values.metrics.podMonitors.extraMetricProcessingRules }}

the condition for

• .Values.metrics.extraMetricRelabelingRules
• .Values.metrics.podMonitors.extraMetricRelabelingRules

is missing. Therefore this values have no effect anymore, because the needed prometheus.relabel "podmonitors" doesn't get created anymore.

metrics:
  extraMetricRelabelingRules: |-
    rule {
        source_labels = ["namespace"]
        regex = "^kube-system$"
        action = "drop"
    }

I also recognized that the value extraMetricProcessingRules is not documented and used anywhere in the v1 chart, so maybe this condition is just a copy-paste-error from the v2 chart?

The same is true for the conditions for probes and servicemonitors

[petewall]

Absolutely, a copy-paste error. I'll fix right away!