open() should not be able to make HTTP requests fix #963

[mstoykov]

No description provided.

[codecov]

Codecov Report

Merging #965 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #965   +/-   ##
=======================================
  Coverage   72.08%   72.08%           
=======================================
  Files         131      131           
  Lines        9601     9601           
=======================================
  Hits         6921     6921           
  Misses       2267     2267           
  Partials      413      413

Impacted Files	Coverage Δ
js/initcontext.go	100% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 672769c...7123357. Read the comment docs.

[codecov]

Codecov Report

Merging #965 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #965      +/-   ##
=========================================
+ Coverage   72.08%   72.1%   +0.01%     
=========================================
  Files         131     131              
  Lines        9602    9615      +13     
=========================================
+ Hits         6922    6933      +11     
- Misses       2267    2268       +1     
- Partials      413     414       +1

Impacted Files	Coverage Δ
js/initcontext.go	97.75% <100%> (-2.25%)	⬇️
lib/archive.go	87.24% <100%> (+0.17%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b1161c...5e80aa4. Read the comment docs.

[na--]

Mostly LGTM now, besides that comment for checking the filename parameter for sanity 😄 . I checked, and nodejs also opens relative file paths based on the current working directory: https://nodejs.org/api/fs.html#fs_file_paths

Though they have a big UX advantage in the __dirname and __filename constants. We might want to introduce the same constants in k6 as well, though in a separate issue/PR. @robingustafsson, thoughts?