From fb71278545d5626b9d3fd7a3f7b56b82b528bdcc Mon Sep 17 00:00:00 2001 From: ka3de Date: Tue, 26 Sep 2023 09:53:48 +0200 Subject: [PATCH 1/4] Add browser's page.on('console') to release notes --- release notes/v0.47.0.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/release notes/v0.47.0.md b/release notes/v0.47.0.md index 4167b4f72fe..3501f3d216f 100644 --- a/release notes/v0.47.0.md +++ b/release notes/v0.47.0.md @@ -37,6 +37,10 @@ Thanks, @sapphire-janrain, for contribution! In some workflows the reflection call should also include some metadata. This PR adds [a new connection parameter `reflectMetadata`](https://k6.io/docs/javascript-api/k6-net-grpc/client/client-connect/#connectparams) that allows to specify the metadata to be sent with the reflection call. +### Add support for browser module's `page.on('console')` [xk6-browser#1006](https://github.com/grafana/xk6-browser/pull/1006) + +Allows users to register a handler to be executed every time the `console` API methods are called from within the page JavaScript context. + ### UX improvements and enhancements _Format as ` . `_: From 798605c5cbfe6195ff2b359532e38b66f38cac59 Mon Sep 17 00:00:00 2001 From: ka3de Date: Tue, 26 Sep 2023 13:59:04 +0200 Subject: [PATCH 2/4] Address CR comments Co-authored-by: Ankur --- release notes/v0.47.0.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/release notes/v0.47.0.md b/release notes/v0.47.0.md index 3501f3d216f..33cbb48c748 100644 --- a/release notes/v0.47.0.md +++ b/release notes/v0.47.0.md @@ -39,7 +39,7 @@ In some workflows the reflection call should also include some metadata. This PR ### Add support for browser module's `page.on('console')` [xk6-browser#1006](https://github.com/grafana/xk6-browser/pull/1006) -Allows users to register a handler to be executed every time the `console` API methods are called from within the page JavaScript context. +Allows users to register a handler to be executed every time the `console` API methods are called from within the page's JavaScript context. ### UX improvements and enhancements From 3923484f7cce705ff9a379c43183638c58aeda48 Mon Sep 17 00:00:00 2001 From: ka3de Date: Tue, 26 Sep 2023 14:08:15 +0200 Subject: [PATCH 3/4] Rename browser PR link Renames it in order to replace the xk6-browser references to use the format browser#PR instead. --- release notes/v0.47.0.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/release notes/v0.47.0.md b/release notes/v0.47.0.md index 33cbb48c748..25a5095e6f8 100644 --- a/release notes/v0.47.0.md +++ b/release notes/v0.47.0.md @@ -37,7 +37,7 @@ Thanks, @sapphire-janrain, for contribution! In some workflows the reflection call should also include some metadata. This PR adds [a new connection parameter `reflectMetadata`](https://k6.io/docs/javascript-api/k6-net-grpc/client/client-connect/#connectparams) that allows to specify the metadata to be sent with the reflection call. -### Add support for browser module's `page.on('console')` [xk6-browser#1006](https://github.com/grafana/xk6-browser/pull/1006) +### Add support for browser module's `page.on('console')` [browser#1006](https://github.com/grafana/xk6-browser/pull/1006) Allows users to register a handler to be executed every time the `console` API methods are called from within the page's JavaScript context. From 2d9bbb17199984a0df1c08f533d2c4e5892db6ca Mon Sep 17 00:00:00 2001 From: ka3de Date: Wed, 27 Sep 2023 09:17:06 +0200 Subject: [PATCH 4/4] Add reference to ConsoleMessage docs --- release notes/v0.47.0.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/release notes/v0.47.0.md b/release notes/v0.47.0.md index 25a5095e6f8..bb3552215bb 100644 --- a/release notes/v0.47.0.md +++ b/release notes/v0.47.0.md @@ -39,7 +39,7 @@ In some workflows the reflection call should also include some metadata. This PR ### Add support for browser module's `page.on('console')` [browser#1006](https://github.com/grafana/xk6-browser/pull/1006) -Allows users to register a handler to be executed every time the `console` API methods are called from within the page's JavaScript context. +Allows users to register a handler to be executed every time the `console` API methods are called from within the page's JavaScript context. The arguments passed into the handler are defined by the (ConsoleMessage)[https://k6.io/docs/javascript-api/k6-experimental/browser/consolemessage/] class. ### UX improvements and enhancements