Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the exit code and run_status value when the cloud output aborts a test #2907

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

na--
Copy link
Member

@na-- na-- commented Feb 9, 2023

This is a fix for #2804 (comment)

@na-- na-- added this to the v0.43.0 milestone Feb 9, 2023
@na-- na-- changed the title Fix the exit code and run_status when the cloud output aborts a test Fix the exit code and run_status value when the cloud output aborts a test Feb 9, 2023
olegbespalov
olegbespalov previously approved these changes Feb 9, 2023
Copy link
Contributor

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@codecov-commenter
Copy link

Codecov Report

Merging #2907 (d6540cd) into master (9c65657) will decrease coverage by 0.11%.
The diff coverage is 85.71%.

❗ Current head d6540cd differs from pull request most recent head 058efe5. Consider uploading reports for the commit 058efe5 to get more accurate results

@@            Coverage Diff             @@
##           master    #2907      +/-   ##
==========================================
- Coverage   76.92%   76.82%   -0.11%     
==========================================
  Files         225      223       -2     
  Lines       16867    16866       -1     
==========================================
- Hits        12975    12957      -18     
- Misses       3061     3072      +11     
- Partials      831      837       +6     
Flag Coverage Δ
ubuntu 76.82% <85.71%> (-0.04%) ⬇️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
errext/abort_reason.go 50.00% <ø> (ø)
output/cloud/output.go 85.18% <85.71%> (+0.17%) ⬆️
loader/filesystems.go 60.00% <0.00%> (-40.00%) ⬇️
js/common/initenv.go 66.66% <0.00%> (-33.34%) ⬇️
api/v1/metric.go 54.54% <0.00%> (-9.10%) ⬇️
cmd/tests/test_state.go 87.75% <0.00%> (-4.09%) ⬇️
metrics/metric_type.go 78.94% <0.00%> (-3.51%) ⬇️
lib/netext/httpext/error_codes.go 94.52% <0.00%> (-2.74%) ⬇️
lib/testutils/minirunner/minirunner.go 74.32% <0.00%> (-2.71%) ⬇️
js/initcontext.go 86.61% <0.00%> (-1.58%) ⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

output/cloud/output.go Outdated Show resolved Hide resolved
@na-- na-- merged commit a78916c into master Feb 9, 2023
@na-- na-- deleted the fix-cloud-output-test-stop branch February 9, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants