Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log field for the VU's ID #2361

Closed
codebien opened this issue Jan 28, 2022 · 2 comments
Closed

Log field for the VU's ID #2361

codebien opened this issue Jan 28, 2022 · 2 comments
Labels

Comments

@codebien
Copy link
Contributor

Feature Description

In some cases, like this forum question, can be helpful to know which specific VU is executing the code or just know that the logs are generated by one of the VUID == 0 (options resolution, babel transpiler, setup, teardown, handle summary).

This was originally proposed during the Init Context's implementation of the console.log.

Suggested Solution (optional)

And if we can fix the configuration challenges you describe (sob), have proper loggers per-VU, and actually implement #889 and attach (via log.WithFields()) the VU ID to each log message, any user confusion from multiple identical messages will likely disappear.

This suggested solution from the original issue is still a valid option.

Already existing or connected issues / PRs (optional)

#951
#2344 - We want to deprecate common.Bind that is how the console.log is defined. A refactor on that side will be for sure beneficial also for the current issue.

@mstoykov
Copy link
Contributor

I am not so certain this will help so much as a bunch of those will be VU=0

And to be honest this is a thing a user can add to the log every time if they so desire along with any other information.

Having it by default will likely just make everything more noisy than anything 🤷

@codebien
Copy link
Contributor Author

codebien commented Jul 8, 2024

Considering the lack of reactions it sounds like a not very requested feature.

@codebien codebien closed this as not planned Won't fix, can't repro, duplicate, stale Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants