Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thresholds console output format #1675

Closed
ppcano opened this issue Oct 19, 2020 · 2 comments
Closed

Thresholds console output format #1675

ppcano opened this issue Oct 19, 2020 · 2 comments
Labels
enhancement evaluation needed proposal needs to be validated or tested before fully implementing it in k6 ux

Comments

@ppcano
Copy link
Contributor

ppcano commented Oct 19, 2020

k6 shows the threshold result as a success (✓) or failure (✗).

Given:

  failed_requests: ["rate<0.1"],
  http_req_duration: ["p(95)<500", "p(90)<1500"]

The k6 output could be:

✓ failed_requests............: 0.00%  ✓ 0    ✗ 8970 
✓ http_req_duration..........: avg=131.22ms min=115.29ms med=124.77ms max=260.27ms p(90)=150.87ms p(95)=162.87ms

I suggest a change to the threshold output to show the existing threshold configuration.

Here a suggestion inline with the current format:

failed_requests............: 0.00%  ✓ 0    ✗ 8970
 └─ ✓ rate<0.1 
http_req_duration..........: avg=131.22ms min=115.29ms med=124.77ms max=260.27ms p(90)=150.87ms p(95)=162.87ms
 └─ ✓ p(90)<1500
 └─ ✓ p(95)<500

Showing this information is useful in case you didn't remember the threshold configuration or you changed it between test runs.

@ppcano ppcano added the feature label Oct 19, 2020
@na-- na-- added enhancement evaluation needed proposal needs to be validated or tested before fully implementing it in k6 ux and removed feature labels Oct 19, 2020
@na--
Copy link
Member

na-- commented Oct 19, 2020

it's probably a good idea, but we have to consider how this will mesh with sub-metrics and thresholds defined on them. This is also somewhat similar to #1319, and is probably going to get resolved by the summary templates proposed in that issue as well.

@na--
Copy link
Member

na-- commented Jan 21, 2021

@ppcano, now that we have handleSummary() (#1768) and k6-summary in jslib, I think I should close this.

In k6 v0.31.0, we want to replace the Go summary generation code with the one from jslib (#1806), so if you think you have a workaround to the issue I raised above, please open a new issue in the jslib repo, or even a PR that adds the desired behavior as an option to generateTextSummary().

@na-- na-- closed this as completed Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement evaluation needed proposal needs to be validated or tested before fully implementing it in k6 ux
Projects
None yet
Development

No branches or pull requests

2 participants