Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve warning messages in arrival-rate executors #1407

Closed
na-- opened this issue Apr 24, 2020 · 1 comment
Closed

Improve warning messages in arrival-rate executors #1407

na-- opened this issue Apr 24, 2020 · 1 comment

Comments

@na--
Copy link
Member

na-- commented Apr 24, 2020

Somewhat related to #1386 (comment), we shouldn't spam warning for every insufficient VU in a badly configured constant-arrival-rate or variable-arrival-rate test. We probably should emit a single warning every timeUnit interval with the number of VUs that were insufficient to run iterations on, and how many iterations were not executed because of that. We should likely emit the same information (and maybe how many additional VUs were allocated) as a metric, so that it's visible in the end of test summary and so we can alert users in the cloud for their badly configured tests.

@na-- na-- added this to the v1.0.0 milestone Apr 24, 2020
@na-- na-- modified the milestones: v1.0.0, v0.28.0 May 21, 2020
@na-- na-- modified the milestones: v0.28.0, v0.27.0 Jul 8, 2020
@na--
Copy link
Member Author

na-- commented Jul 8, 2020

This was actually mostly fixed as a part of #1500 and #1529 - we can have more improvements, of course, but we should make a new issue for them.

@na-- na-- closed this as completed Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant