Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate and improve IP blacklisting performance #1256

Closed
na-- opened this issue Nov 27, 2019 · 1 comment
Closed

Investigate and improve IP blacklisting performance #1256

na-- opened this issue Nov 27, 2019 · 1 comment
Labels
evaluation needed proposal needs to be validated or tested before fully implementing it in k6 performance

Comments

@na--
Copy link
Member

na-- commented Nov 27, 2019

The current IP blacklisting code is very naive and unoptimized: https://github.com/loadimpact/k6/blob/a2e1c6f4e6207d69461a1b0f24c3aa2c72233101/lib/netext/dialer.go#L84-L88

We need to investigate whether that's an issue when we have hundreds of IP ranges blacklisted... If it is, we probably should use something like https://github.com/yl2chen/cidranger
@na-- na-- added performance evaluation needed proposal needs to be validated or tested before fully implementing it in k6 labels Nov 27, 2019
@na-- na-- mentioned this issue Jun 24, 2020
Closed
@olegbespalov
Copy link
Contributor

After an internal conversation, we decided to close the issue since the original case wasn't an issue. If our users found out any performance issue we could re-open the issue again.

@olegbespalov olegbespalov closed this as not planned Won't fix, can't repro, duplicate, stale Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
evaluation needed proposal needs to be validated or tested before fully implementing it in k6 performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@na-- @olegbespalov