Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create multi-message WebSockets test #1152

Closed
imiric opened this issue Sep 11, 2019 · 1 comment · Fixed by #2184
Closed

Create multi-message WebSockets test #1152

imiric opened this issue Sep 11, 2019 · 1 comment · Fixed by #2184

Comments

@imiric
Copy link
Contributor

imiric commented Sep 11, 2019

While working on fixing the flaky TestSentReceivedMetrics (PR #1149) we noticed that all our current WS tests only test sending one message and disconnecting.

This issue is to add one or more tests where more than one message is passed, which will require a change in websocketEchoHandler() to avoid disconnecting after the first message.

Since the WS handler can impact test flakiness, make sure to test this change thoroughly.

@imiric imiric added the tests label Sep 11, 2019
@imiric imiric added this to the v0.26.0 milestone Sep 11, 2019
@na-- na-- modified the milestones: v0.26.0, v0.27.0 Oct 10, 2019
@na-- na-- modified the milestones: v0.27.0, v0.28.0 May 21, 2020
@na-- na-- removed this from the v0.28.0 milestone Sep 9, 2020
@cooliscool
Copy link
Contributor

Hi 👋 I'm interested to take this up.

@imiric imiric linked a pull request Oct 15, 2021 that will close this issue
@na-- na-- added this to the v0.35.0 milestone Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants