Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix line numbers in imports #1107

Closed
mstoykov opened this issue Aug 7, 2019 · 1 comment
Closed

Fix line numbers in imports #1107

mstoykov opened this issue Aug 7, 2019 · 1 comment

Comments

@mstoykov
Copy link
Contributor

mstoykov commented Aug 7, 2019

Because of the way we wrap imports, we add an additional 1 to all line numbers. (this is not true for the main script because it special ... for now). This is somewhat annoying and definitely problematic in big scripts when the error is cryptic to begin with.
We should be able to utilize sourcemaps given that goja supports them and we already have some code that reads them even though they were disabled and I can't find them ever being used ... ;(

@na--
Copy link
Member

na-- commented Jan 26, 2021

Closing this in favor of #1804, since it's more detailed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants