From 872ce2c0283cfbf04c204355ccc38d4ab24965ae Mon Sep 17 00:00:00 2001 From: Mihail Stoykov <312246+mstoykov@users.noreply.github.com> Date: Mon, 22 Apr 2024 10:35:00 +0300 Subject: [PATCH] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Joan López de la Franca Beltran <5459617+joanlopez@users.noreply.github.com> --- js/modules/require_impl.go | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/js/modules/require_impl.go b/js/modules/require_impl.go index ddc64dad763b..0f0833eaaac2 100644 --- a/js/modules/require_impl.go +++ b/js/modules/require_impl.go @@ -90,10 +90,10 @@ func (r *LegacyRequireImpl) warnUserOnPathResolutionDifferences(specifier string if err != nil { logger.Warningf("Couldn't get the \"correct\" path to resolve specifier %q against: %q"+ "Please report to issue %s. "+ - "This will not currently break your script but might mean the future it won't work", + "This will not currently break your script but it might mean that in the future it won't work", specifier, err, issueLink) } else if r.currentlyRequiredModule.String() != correct.String() { - logger.Warningf("The \"wrong\" path (%q) and the actually used by k6 path (%q) to resolve %q are different. "+ + logger.Warningf("The \"wrong\" path (%q) and the path actually used by k6 (%q) to resolve %q are different. "+ "Please report to issue %s. "+ "This will not currently break your script but *WILL* in the future, please report this!!!", correct, r.currentlyRequiredModule, specifier, issueLink) @@ -103,7 +103,7 @@ func (r *LegacyRequireImpl) warnUserOnPathResolutionDifferences(specifier string if err != nil { logger.Warningf("Couldn't get the \"wrong\" path to resolve specifier %q against: %q"+ "Please report to issue %s. "+ - "This will not currently break your script but might mean the future it won't work", + "This will not currently break your script but it might mean that in the future it won't work", specifier, err, issueLink) return } @@ -111,15 +111,15 @@ func (r *LegacyRequireImpl) warnUserOnPathResolutionDifferences(specifier string if err != nil { logger.Warningf("Couldn't get the \"wrong\" path to resolve specifier %q against: %q"+ "Please report to issue %s. "+ - "This will not currently break your script but might mean the future it won't work", + "This will not currently break your script but it might mean that in the future it won't work", specifier, err, issueLink) return } if r.currentlyRequiredModule.String() != k6behaviour.String() { // this should always be equal, but check anyway to be certain we won't break something - logger.Warningf("The \"wrong\" path (%q) and the actually used by k6 path (%q) to resolve %q are different. "+ + logger.Warningf("The \"wrong\" path (%q) and the path actually used by k6 (%q) to resolve %q are different. "+ "Please report to issue %s. "+ - "This will not currently break your script but might mean the future it won't work", + "This will not currently break your script but it might mean that in the future it won't work", k6behaviour, r.currentlyRequiredModule, specifier, issueLink) } }