From 2904961a2cb2b59928a98d5f349788cfcc75628e Mon Sep 17 00:00:00 2001
From: Mihail Stoykov <MStoykov@users.noreply.github.com>
Date: Wed, 13 Jan 2021 14:05:50 +0200
Subject: [PATCH] Add/move SharedArray tests to it's module (#1795)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Ivan Mirić <ivan@loadimpact.com>
---
 js/modules/k6/data/share_test.go | 189 +++++++++++++++++++++++++++++++
 js/share_test.go                 |  76 +------------
 2 files changed, 190 insertions(+), 75 deletions(-)
 create mode 100644 js/modules/k6/data/share_test.go

diff --git a/js/modules/k6/data/share_test.go b/js/modules/k6/data/share_test.go
new file mode 100644
index 00000000000..dce89b79aa8
--- /dev/null
+++ b/js/modules/k6/data/share_test.go
@@ -0,0 +1,189 @@
+/*
+ *
+ * k6 - a next-generation load testing tool
+ * Copyright (C) 2020 Load Impact
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
+package data
+
+import (
+	"context"
+	"testing"
+
+	"github.com/dop251/goja"
+	"github.com/loadimpact/k6/js/common"
+	"github.com/stretchr/testify/require"
+)
+
+const makeArrayScript = `
+var array = new data.SharedArray("shared",function() {
+    var n = 50;
+    var arr = new Array(n);
+    for (var i = 0 ; i <n; i++) {
+        arr[i] = {value: "something" +i};
+    }
+	return arr;
+});
+`
+
+func newConfiguredRuntime(initEnv *common.InitEnvironment) (*goja.Runtime, error) {
+	rt := goja.New()
+	rt.SetFieldNameMapper(common.FieldNameMapper{})
+
+	ctx := common.WithInitEnv(context.Background(), initEnv)
+	ctx = common.WithRuntime(ctx, rt)
+	rt.Set("data", common.Bind(rt, new(data), &ctx))
+	_, err := rt.RunString("var SharedArray = data.SharedArray;")
+
+	return rt, err
+}
+
+func TestSharedArrayConstructorExceptions(t *testing.T) {
+	t.Parallel()
+	initEnv := &common.InitEnvironment{
+		SharedObjects: common.NewSharedObjects(),
+	}
+	rt, err := newConfiguredRuntime(initEnv)
+	require.NoError(t, err)
+	cases := map[string]struct {
+		code, err string
+	}{
+		"returning string": {
+			code: `new SharedArray("wat", function() {return "whatever"});`,
+			err:  "only arrays can be made into SharedArray",
+		},
+		"empty name": {
+			code: `new SharedArray("", function() {return []});`,
+			err:  "empty name provided to SharedArray's constructor",
+		},
+		"function in the data": {
+			code: `
+			var s = new SharedArray("wat2", function() {return [{s: function() {}}]});
+			if (s[0].s !== undefined) {
+				throw "s[0].s should be undefined"
+			}
+		`,
+			err: "",
+		},
+	}
+
+	for name, testCase := range cases {
+		name, testCase := name, testCase
+		t.Run(name, func(t *testing.T) {
+			_, err := common.RunString(rt, testCase.code)
+			if testCase.err == "" {
+				require.NoError(t, err)
+				return // the t.Run
+			}
+
+			require.Error(t, err)
+			exc := err.(*goja.Exception)
+			require.Contains(t, exc.Error(), testCase.err)
+		})
+	}
+}
+
+func TestSharedArrayAnotherRuntimeExceptions(t *testing.T) {
+	t.Parallel()
+
+	initEnv := &common.InitEnvironment{
+		SharedObjects: common.NewSharedObjects(),
+	}
+	rt, err := newConfiguredRuntime(initEnv)
+	require.NoError(t, err)
+	_, err = rt.RunString(makeArrayScript)
+	require.NoError(t, err)
+
+	// create another Runtime with new ctx but keep the initEnv
+	rt, err = newConfiguredRuntime(initEnv)
+	require.NoError(t, err)
+	_, err = rt.RunString(makeArrayScript)
+	require.NoError(t, err)
+
+	// use strict is required as otherwise just nothing happens
+	cases := map[string]struct {
+		code, err string
+	}{
+		"setting in for-of": {
+			code: `'use strict'; for (var v of array) { v.data = "bad"; }`,
+			err:  "Cannot add property data, object is not extensible",
+		},
+		"setting from index": {
+			code: `'use strict'; array[2].data2 = "bad2"`,
+			err:  "Cannot add property data2, object is not extensible",
+		},
+		"setting property on the proxy": {
+			code: `'use strict'; array.something = "something"`,
+			err:  "Host object field something cannot be made configurable",
+		},
+		"setting index on the proxy": {
+			code: `'use strict'; array[2] = "something"`,
+			err:  "Host object field 2 cannot be made configurable",
+		},
+	}
+
+	for name, testCase := range cases {
+		name, testCase := name, testCase
+		t.Run(name, func(t *testing.T) {
+			_, err := rt.RunString(testCase.code)
+			if testCase.err == "" {
+				require.NoError(t, err)
+				return // the t.Run
+			}
+
+			require.Error(t, err)
+			exc := err.(*goja.Exception)
+			require.Contains(t, exc.Error(), testCase.err)
+		})
+	}
+}
+
+func TestSharedArrayAnotherRuntimeWorking(t *testing.T) {
+	t.Parallel()
+
+	initEnv := &common.InitEnvironment{
+		SharedObjects: common.NewSharedObjects(),
+	}
+	rt, err := newConfiguredRuntime(initEnv)
+	require.NoError(t, err)
+	_, err = rt.RunString(makeArrayScript)
+	require.NoError(t, err)
+
+	// create another Runtime with new ctx but keep the initEnv
+	rt, err = newConfiguredRuntime(initEnv)
+	require.NoError(t, err)
+	_, err = rt.RunString(makeArrayScript)
+	require.NoError(t, err)
+
+	_, err = rt.RunString(`
+	if (array[2].value !== "something2") {
+		throw new Error("bad array[2]="+array[2].value);
+	}
+	if (array.length != 50) {
+		throw new Error("bad length " +array.length);
+	}
+
+	var i = 0;
+	for (var v of array) {
+		if (v.value !== "something"+i) {
+			throw new Error("bad v.value="+v.value+" for i="+i);
+		}
+		i++;
+	}
+	`)
+	require.NoError(t, err)
+}
diff --git a/js/share_test.go b/js/share_test.go
index 760f88dd1a1..af537d1a26f 100644
--- a/js/share_test.go
+++ b/js/share_test.go
@@ -33,7 +33,7 @@ import (
 	"github.com/stretchr/testify/require"
 )
 
-func TestInitContextNewSharedArray(t *testing.T) {
+func TestNewSharedArrayIntegration(t *testing.T) {
 	data := `'use strict';
 var SharedArray = require("k6/data").SharedArray;
 function generateArray() {
@@ -48,39 +48,6 @@ function generateArray() {
 
 var s = new SharedArray("something", generateArray);
 
-try {
-	var p = new SharedArray("wat", function() {return "whatever"});
-	throw "the previous line should've errored as we returned a string not array";
-} catch (e) {
-	if (!e.toString().includes("only arrays can be made into SharedArray")) {
-		throw "wrong error " + e.toString();
-	}
-}
-
-try {
-	var p = new SharedArray("", generateArray);
-	throw "the previous line should've errored as we provided an empty name";
-} catch (e){
-	if (!e.toString().includes("empty name provided to SharedArray's constructor")) {
-		throw "wrong error " + e.toString();
-	}
-}
-
-try {
-	var p = new SharedArray("wat2", function() {return [{s: function() {return "whatever"}}]});
-	// throw "the previous line should've errored as function was stringified";
-	// unfortunately JSON.stringify is defined that it will acctually just remove stuff (or make them null)
-	// that can't be JSONified like functions
-	if (p[0].s != undefined) {
-		throw "only arrays can be made into SharedArray";
-	}
-} catch (e) {
-	if (!e.toString().includes("only arrays can be made into SharedArray")) {
-		throw "wrong error " + e.toString();
-	}
-}
-
-
 exports.default = function() {
 	if (s[2].value !== "something2") {
 		throw new Error("bad s[2]="+s[2].value);
@@ -95,47 +62,6 @@ exports.default = function() {
 			throw new Error("bad v.value="+v.value+" for i="+i);
 		}
 		i++;
-
-		try {
-			v.data = "help";
-			throw "the previous line should've errored v.data = 'help'";
-		} catch(e) {
-			if (!e.toString().includes("TypeError: Cannot add property data, object is not extensible")) {
-				throw "wrong error " + e.toString();
-			}
-		}
-	}
-
-	try {
-		s[2].data = "help";
-		throw "the previous line should've errored s[2].data = 'help'";
-	} catch(e) {
-		if (!e.toString().includes("TypeError: Cannot add property data, object is not extensible")) {
-			throw "wrong error " + e.toString();
-		}
-	}
-
-	if (s.something != undefined) {
-		throw "s.something should've been undefined but was " + s.something;
-	}
-
-	try {
-		s.something = 21
-		throw "the previous line should've errored s.something = 21";
-	} catch(e) {
-		if (!e.toString().includes("Host object field something cannot be made configurable")) {
-			throw "wrong error " + e.toString();
-		}
-	}
-
-	try {
-		s[1]= "21";
-
-		throw "the previous line should've errored";
-	} catch(e) {
-		if (!e.toString().includes("Host object field 1 cannot be made configurable")) {
-			throw "wrong error " + e.toString();
-		}
 	}
 }`