From 1020b306613f88a8eab64ff868b083ddb9fb5248 Mon Sep 17 00:00:00 2001 From: Mihail Stoykov Date: Thu, 25 Apr 2024 10:53:00 +0300 Subject: [PATCH] golangci-lint: enable it for all issues not just new As now all lint issues are fixed we can enable without that option. Unfortunately the option only looks at code at and around the places that was changed and if any of it has new lint errors it will trigger. That does mean that if you update golangci-lint - it won't showcase new lint errors it triggers. Also won't work if you add a bunch of code to the end an already somewhat long function. As the lint error will be at the beginning of the function. Closes #769 --- .github/actions/lint/action.yml | 1 - Makefile | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/actions/lint/action.yml b/.github/actions/lint/action.yml index 742a3c74331..43c44925b15 100644 --- a/.github/actions/lint/action.yml +++ b/.github/actions/lint/action.yml @@ -28,5 +28,4 @@ runs: uses: golangci/golangci-lint-action@349d20632dbaed38f0a492cc991152e3d351e854 # latest commit at the time that uses node20 with: version: ${{ steps.getenv.outputs.GolangCIVersion }} - only-new-issues: true args: "--config=${{ github.action_path }}/.golangci.yml" diff --git a/Makefile b/Makefile index e990dfcd3f2..e9f117a25f0 100644 --- a/Makefile +++ b/Makefile @@ -22,7 +22,7 @@ check-linter-version: ## lint: Runs the linters. lint: check-linter-version echo "Running linters..." - golangci-lint run --out-format=tab --new-from-rev master ./... + golangci-lint run --out-format=tab ./... ## tests: Executes any unit tests. tests: