Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: ability to add custom cert or disable cert validation in S3 endpoint #91

Open
rgordill opened this issue Jan 8, 2024 · 2 comments

Comments

@rgordill
Copy link

rgordill commented Jan 8, 2024

Hi.

When using the s3.js functions, if the s3 endpoint is an internal one with custom certs, it throws an error:

level=warning msg="Request Failed" error="Put "[https://s3.internal.com:443/k6-s3/results-1-0.json](https://s3.internal.com/k6-s3/results-1-0.json%5C)": tls: failed to verify certificate: x509: certificate signed by unknown authority"

This is an usual situation when using minio, ceph rgw, etc. We need an option to disable cert validation (non sensible envs) or add custom certs to validate them correctly.

@github-actions github-actions bot added the triage label Jan 8, 2024
@joanlopez joanlopez added enhancement New feature or request and removed triage labels Jan 23, 2024
@joanlopez
Copy link
Contributor

Hi @rgordill,

First of all, sorry for the delayed answer 🙏🏻

That being said, I'd like to ask you: have you tried with either Insecure skip TLS verify or TLS auth k6 options?

If I'm not wrong, the S3Client relies on standard k6 http client (see here and its usages), and as explained here, these are the options to configure TLS.

Thanks!

@joanlopez joanlopez added awaiting user and removed enhancement New feature or request labels Jan 23, 2024
@joanlopez joanlopez removed their assignment Jan 23, 2024
@rgordill
Copy link
Author

Hi, @joanlopez.

Yes, I made it working by disabling validation globally with the procedure you have mentioned. But IMHO, there should be a particular configuration that impacts only to the S3Client, while we use the former workaround.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants