Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lowercase Kinesis interfaces and classes property names #52

Closed
oleiade opened this issue Jun 28, 2023 · 0 comments
Closed

lowercase Kinesis interfaces and classes property names #52

oleiade opened this issue Jun 28, 2023 · 0 comments
Labels
good first issue Good for newcomers
Milestone
0.9.0

Comments

@oleiade
Copy link
Member

oleiade commented Jun 28, 2023

As we ported the initial Pull Request implementing support for Kinesis, we completely forgot to adjust the various interfaces and classes naming to our pre-existing convention: lowercase first letter.

We should make sure to change that for consistency purposes, and also because it results in an API that "feels" strange.
@oleiade oleiade added the good first issue Good for newcomers label Jun 28, 2023
@oleiade oleiade added this to the 0.9.0 milestone Jun 28, 2023
@oleiade oleiade closed this as completed in ddcd290 Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
1 participant
@oleiade