-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[agent-operator] Move crds(agent, prometheus) into separate subcharts #2781
base: main
Are you sure you want to change the base?
Conversation
476b93c
to
e15f509
Compare
man, i need this! |
@kuzm1ch i think that you need mark the code owner for this code for PR is to review. |
@Vinaum8 agent-operator is not in a list in the https://github.com/grafana/helm-charts/blob/main/.github/CODEOWNERS, so I'll tag @grafana/helm-charts-admins. If this simple PR is ok in general for @grafana/helm-charts-admins, I will fix conflicts and it can be merged. |
@maorfr @torstenwalter @Xtigyro @zanhsieh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kuzm1ch
Can you fix the conflicts please?
e15f509
to
35974e8
Compare
done |
@zanhsieh still need something in this PR? |
@Vinaum8 Grafana repo required two approvals in order to merge, so nothing I can do now. |
Thanks man! |
It would be awesome if we could merge this. We're managing CRDs separately from the Helm chart deployment and have issues integrating this chart. |
me too. i waiting for this merge. |
dec583e
to
de3fc9e
Compare
PR updates:
|
…harts Signed-off-by: Mykhailo Kuzmich <[email protected]>
Signed-off-by: Mykhailo Kuzmich <[email protected]>
Signed-off-by: Mykhailo Kuzmich <[email protected]>
de3fc9e
to
f58a20b
Compare
Fix: grafana/loki#7488
These changes allow users to disable installation of specific CRD groups so users can avoid the situation when multiple helm charts manage/install the same CRDs.
Also, moving CRDs into subchart has some other benefits - prometheus-community/helm-charts#3548.