Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin is failing to render in new Scenes architecture #1819

Closed
bfmatei opened this issue Apr 17, 2024 · 1 comment · Fixed by #1822
Closed

Plugin is failing to render in new Scenes architecture #1819

bfmatei opened this issue Apr 17, 2024 · 1 comment · Fixed by #1822
Assignees

Comments

@bfmatei
Copy link

bfmatei commented Apr 17, 2024

Describe the bug
After the migration of core dashboards to the Scenes architecture, we got an escalation regarding some issues with the Zabbix plugin.

The issue is pretty simple: the plugin is doing a caching by stringifing a set of arguments among which is the request. Unlike in the previous implementation, in the current one the request contains circular references and it can't be stringified without using a circular reference removal (my go-to solution to this) or by manually removing the complex objects from the request object.

Expected behavior
The plugin should not fail.

Screenshots
Screenshot 2024-04-17 at 11 44 22
Screenshot 2024-04-17 at 11 44 38

Network data

Software versions

Grafana Zabbix Grafana-Zabbix Plugin
11.1.x --- 4.4.3
@gabor gabor self-assigned this Apr 17, 2024
@gabor
Copy link
Contributor

gabor commented Apr 19, 2024

how to reproduce:

  • run zabbix in direct-db-connection mode
  • create a dashboard with a zabbix query
  • add &scenes to the end of the dashboard-url to trigger scenes-mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging a pull request may close this issue.

2 participants