From 72d44c14fc1bba3c9eb725c4af4bb9b811b3fb3a Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 18 Sep 2023 09:43:47 +0000 Subject: [PATCH 01/14] chore(deps): bump github.com/grafana/grafana-api-golang-client Bumps [github.com/grafana/grafana-api-golang-client](https://github.com/grafana/grafana-api-golang-client) from 0.23.0 to 0.24.0. - [Release notes](https://github.com/grafana/grafana-api-golang-client/releases) - [Commits](https://github.com/grafana/grafana-api-golang-client/compare/v0.23.0...v0.24.0) --- updated-dependencies: - dependency-name: github.com/grafana/grafana-api-golang-client dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- go.mod | 2 +- go.sum | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/go.mod b/go.mod index df71c88af..81c1dd420 100644 --- a/go.mod +++ b/go.mod @@ -7,7 +7,7 @@ require ( github.com/blang/semver v3.5.1+incompatible github.com/go-logr/logr v1.2.4 github.com/google/go-jsonnet v0.20.0 - github.com/grafana/grafana-api-golang-client v0.23.0 + github.com/grafana/grafana-api-golang-client v0.24.0 github.com/onsi/ginkgo v1.16.5 github.com/onsi/gomega v1.27.10 github.com/openshift/api v3.9.0+incompatible diff --git a/go.sum b/go.sum index 043f069ea..4c9a391e6 100644 --- a/go.sum +++ b/go.sum @@ -67,8 +67,8 @@ github.com/google/gofuzz v1.2.0/go.mod h1:dBl0BpW6vV/+mYPU4Po3pmUjxk6FQPldtuIdl/ github.com/google/pprof v0.0.0-20210720184732-4bb14d4b1be1 h1:K6RDEckDVWvDI9JAJYCmNdQXq6neHJOYx3V6jnqNEec= github.com/google/uuid v1.3.0 h1:t6JiXgmwXMjEs8VusXIJk2BXHsn+wx8BZdTaoZ5fu7I= github.com/google/uuid v1.3.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo= -github.com/grafana/grafana-api-golang-client v0.23.0 h1:Uta0dSkxWYf1D83/E7MRLCG69387FiUc+k9U/35nMhY= -github.com/grafana/grafana-api-golang-client v0.23.0/go.mod h1:24W29gPe9yl0/3A9X624TPkAOR8DpHno490cPwnkv8E= +github.com/grafana/grafana-api-golang-client v0.24.0 h1:9cUvft7xCMnnL/Uscwy7eoldn16Gz5TH4T1MymuVs8E= +github.com/grafana/grafana-api-golang-client v0.24.0/go.mod h1:24W29gPe9yl0/3A9X624TPkAOR8DpHno490cPwnkv8E= github.com/hashicorp/go-cleanhttp v0.5.2 h1:035FKYIWjmULyFRBKPs8TBQoi0x6d9G4xc9neXJWAZQ= github.com/hashicorp/go-cleanhttp v0.5.2/go.mod h1:kO/YDlP8L1346E6Sodw+PrpBSV4/SoxCXGY6BqNFT48= github.com/hpcloud/tail v1.0.0/go.mod h1:ab1qPbhIpdTxEkNHXyeSf5vhxWSCs/tWer42PpOxQnU= From d601df97fac9f7f35d4875f0193d8bb0796f7ff1 Mon Sep 17 00:00:00 2001 From: Edvin N Date: Wed, 22 Nov 2023 11:33:48 +0100 Subject: [PATCH 02/14] readd containerImage (#1312) --- .../manifests/bases/grafana-operator.clusterserviceversion.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/config/manifests/bases/grafana-operator.clusterserviceversion.yaml b/config/manifests/bases/grafana-operator.clusterserviceversion.yaml index e8c9dbe93..6f4061f60 100644 --- a/config/manifests/bases/grafana-operator.clusterserviceversion.yaml +++ b/config/manifests/bases/grafana-operator.clusterserviceversion.yaml @@ -5,6 +5,7 @@ metadata: alm-examples: '[]' capabilities: Basic Install categories: Monitoring + containerImage: ghcr.io/grafana-operator/grafana-operator:v5.5.0 createdAt: "2023-09-12T08:09:00.92Z" repository: https://github.com/grafana-operator/grafana-operator support: Community From a9cc7fc584c32826914576814b1cd7b268d24c3f Mon Sep 17 00:00:00 2001 From: Philipp B Date: Thu, 23 Nov 2023 18:26:54 +0100 Subject: [PATCH 03/14] helm chart: fix broken default values after 3166d43 (#1316) Fixes #1315. --- deploy/helm/grafana-operator/README.md | 1 - deploy/helm/grafana-operator/templates/deployment.yaml | 4 ---- deploy/helm/grafana-operator/values.yaml | 7 +++---- 3 files changed, 3 insertions(+), 9 deletions(-) diff --git a/deploy/helm/grafana-operator/README.md b/deploy/helm/grafana-operator/README.md index 7259446f2..1f08ec793 100644 --- a/deploy/helm/grafana-operator/README.md +++ b/deploy/helm/grafana-operator/README.md @@ -38,7 +38,6 @@ It's easier to just manage this configuration outside of the operator. | additionalLabels | object | `{}` | additional labels to add to all resources | | affinity | object | `{}` | pod affinity | | env | list | `[]` | Additional environment variables | -| env.grafanaImage | string | `""` | grafana image, e.g. docker.io/grafana/grafana:9.1.6, overwrites the default grafana image defined in the operator | | fullnameOverride | string | `""` | | | image.pullPolicy | string | `"IfNotPresent"` | The image pull policy to use in grafana operator container | | image.repository | string | `"ghcr.io/grafana-operator/grafana-operator"` | grafana operator image repository | diff --git a/deploy/helm/grafana-operator/templates/deployment.yaml b/deploy/helm/grafana-operator/templates/deployment.yaml index 77d1a204d..db3f2ff0f 100644 --- a/deploy/helm/grafana-operator/templates/deployment.yaml +++ b/deploy/helm/grafana-operator/templates/deployment.yaml @@ -42,10 +42,6 @@ spec: image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}" imagePullPolicy: {{ .Values.image.pullPolicy }} env: - {{- if .Values.env.grafanaImage }} - - name: RELATED_IMAGE_GRAFANA - value: {{ .Values.env.grafanaImage }} - {{- end }} - name: WATCH_NAMESPACE {{- if and .Values.namespaceScope (eq .Values.watchNamespaces "") }} value: {{ .Release.Namespace }} diff --git a/deploy/helm/grafana-operator/values.yaml b/deploy/helm/grafana-operator/values.yaml index deb6e0742..0a3df1e58 100644 --- a/deploy/helm/grafana-operator/values.yaml +++ b/deploy/helm/grafana-operator/values.yaml @@ -12,6 +12,9 @@ watchNamespaces: "" # -- Additional environment variables env: [] + # -- grafana image, e.g. docker.io/grafana/grafana:9.1.6, overwrites the default grafana image defined in the operator + # - name: RELATED_IMAGE_GRAFANA + # value: "docker.io/grafana/grafana:9.1.6" # - name: MY_VAR # value: "myvalue" @@ -26,10 +29,6 @@ image: # -- image pull secrets imagePullSecrets: [] -env: - # -- grafana image, e.g. docker.io/grafana/grafana:9.1.6, overwrites the default grafana image defined in the operator - grafanaImage: "" - nameOverride: "" fullnameOverride: "" From 3d39fd3909e3b84b3e5530329f7f5d03b3c655a6 Mon Sep 17 00:00:00 2001 From: Edvin N Date: Thu, 23 Nov 2023 20:10:08 +0100 Subject: [PATCH 04/14] prepare 5.5.1 (#1317) --- Makefile | 2 +- deploy/helm/grafana-operator/Chart.yaml | 2 +- deploy/helm/grafana-operator/README.md | 4 ++-- hugo/config.toml | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index 91cad8b0b..67129cdd3 100644 --- a/Makefile +++ b/Makefile @@ -2,7 +2,7 @@ # NOTE: this section almost matches outputs out kubebuilder v3.7.0 ### # Current Operator version -VERSION ?= 5.5.0 +VERSION ?= 5.5.1 # BUNDLE_GEN_FLAGS are the flags passed to the operator-sdk generate bundle command BUNDLE_GEN_FLAGS ?= -q --overwrite --version $(VERSION) $(BUNDLE_METADATA_OPTS) diff --git a/deploy/helm/grafana-operator/Chart.yaml b/deploy/helm/grafana-operator/Chart.yaml index a70604084..40081c816 100644 --- a/deploy/helm/grafana-operator/Chart.yaml +++ b/deploy/helm/grafana-operator/Chart.yaml @@ -21,4 +21,4 @@ version: 0.1.1 # incremented each time you make changes to the application. Versions are not expected to # follow Semantic Versioning. They should reflect the version the application is using. # It is recommended to use it with quotes. -appVersion: "v5.5.0" +appVersion: "v5.5.1" diff --git a/deploy/helm/grafana-operator/README.md b/deploy/helm/grafana-operator/README.md index 1f08ec793..163309d91 100644 --- a/deploy/helm/grafana-operator/README.md +++ b/deploy/helm/grafana-operator/README.md @@ -7,14 +7,14 @@ linkTitle: "Helm installation" [grafana-operator](https://github.com/grafana-operator/grafana-operator) for Kubernetes to manage Grafana instances and grafana resources. -![Version: 0.1.1](https://img.shields.io/badge/Version-0.1.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v5.5.0](https://img.shields.io/badge/AppVersion-v5.5.0-informational?style=flat-square) +![Version: 0.1.1](https://img.shields.io/badge/Version-0.1.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v5.5.1](https://img.shields.io/badge/AppVersion-v5.5.1-informational?style=flat-square) ## Installation This is a OCI helm chart, helm started support OCI in version 3.8.0. ```shell -helm upgrade -i grafana-operator oci://ghcr.io/grafana-operator/helm-charts/grafana-operator --version v5.5.0 +helm upgrade -i grafana-operator oci://ghcr.io/grafana-operator/helm-charts/grafana-operator --version v5.5.1 ``` Sadly helm OCI charts currently don't support searching for available versions of a helm [oci registry](https://github.com/helm/helm/issues/11000). diff --git a/hugo/config.toml b/hugo/config.toml index ce8484a43..52b883c61 100644 --- a/hugo/config.toml +++ b/hugo/config.toml @@ -59,7 +59,7 @@ archived_version = false # The version number for the version of the docs represented in this doc set. # Used in the "version-banner" partial to display a version number for the # current doc set. -version = "v5.5.0" +version = "v5.5.1" # A link to latest version of the docs. Used in the "version-banner" partial to # point people to the main doc site. From 8629b6a2ec850db3666ad6a7399fda2ab4ae80dd Mon Sep 17 00:00:00 2001 From: Edvin N Date: Fri, 24 Nov 2023 13:16:38 +0100 Subject: [PATCH 05/14] Run helm template as a basic check of the helm chart (#1318) * Run helm template as a basic check of the helm chart * Update .github/workflows/pr-validation.yaml Co-authored-by: Igor Beliakov <46579601+weisdd@users.noreply.github.com> --------- Co-authored-by: Igor Beliakov <46579601+weisdd@users.noreply.github.com> --- .github/workflows/pr-validation.yaml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/pr-validation.yaml b/.github/workflows/pr-validation.yaml index 99d900663..9fb45d8b1 100644 --- a/.github/workflows/pr-validation.yaml +++ b/.github/workflows/pr-validation.yaml @@ -133,6 +133,13 @@ jobs: with: go-version-file: "go.mod" + - name: Run helm-template + run: | + helm template deploy/helm/grafana-operator/ + + - name: Run helm-lint + run: | + helm lint deploy/helm/grafana-operator/ - name: Run helm-docs run: | make helm/docs From fd353ac36fbf7ecb7c1f38f97d1fe79510d8bf02 Mon Sep 17 00:00:00 2001 From: Hubert Stefanski <35736504+HubertStefanski@users.noreply.github.com> Date: Mon, 27 Nov 2023 11:09:34 +0100 Subject: [PATCH 06/14] blog post entry for upcoming operator repo migration to upstream grafana (#1314) --- .../operator-migration-to-upstream-grafana.md | 91 +++++++++++++++++++ 1 file changed, 91 insertions(+) create mode 100644 docs/blog/operator-migration-to-upstream-grafana.md diff --git a/docs/blog/operator-migration-to-upstream-grafana.md b/docs/blog/operator-migration-to-upstream-grafana.md new file mode 100644 index 000000000..348a991bf --- /dev/null +++ b/docs/blog/operator-migration-to-upstream-grafana.md @@ -0,0 +1,91 @@ +--- +author: "Hubert Stefańksi" +date: 2023-11-21 +title: "Moving Upstream" +linkTitle: "Grafana-Operator Moving Upstream" +description: "An announcement of an upcoming migration to upstream grafana repositories" +--- + +Exciting times coming up! + +The community folks over at upstream Grafana, have reached out and asked if we’d be open to migrating +the Grafana-Operator to their https://github.com/grafana organization! We said "YES!" + +## Why? + +Ever since we moved away from our initial `Integr8ly` home, (where Peter first created the operator) we have focused on +growing the community and improving the user experience as best we could, we believe that moving to upstream Grafana is +the next logical step. + +With this, we hope that the operator gets some more “validity” (for the lack of a better word). With which, we hope new +users and developers will be more likely to engage. Especially given its presence in the official `Grafana` +organization. + +It’s not a secret that the current maintainer team isn’t as active as it could be (believe, us, we want to do more). +But... the grafana-operator is a true side-gig for us, 3/4 of our current active maintainers don't work with Kubernetes +day-to-day. We acknowledge that this is one of the major factors limiting development right now. Where some feature +requests have been open for months at a time, with no one being able to implement them. With our limited time we tend to +focus on fixing bugs and small quality-of-life improvements, however, we know that this is not enough and that the +operator has much greater potential. After all, we only support a few core features, out of numerous possible ones in +Grafana. + +So, the choice is pretty clear for us, considering the slow development speed, and our limited capacity but also wanting +the operator to grow, in all aspects, community, featureset etc., we believe this to be a step in the right direction +for everyone involved. + +## What does it mean for me(as a grafana-operator user)? + +Technically, not much will change, the grafana-operator will still be the grafana-operator you’ve gotten to know, love +and have pulled millions of times (we see the stats 😁). + +We don’t plan on a new API version with this repo migration, at least not in the upcoming quarters, we’re really happy +with how flexible our API is now, so we don’t really have a reason to change anything. + +We also don’t expect existing deployments to be affected in any capacity, and if for any reason that would happen, we'll +be there to help out! + +## What about the maintainers? + +All current Grafana-Operator maintainers are planning on sticking around and continuing on with our involvement in the +project, after all, this is a massive leap for the operator, and we’re all happy to be part of it! + +In all likelihood, new maintainers from the upstream Grafana community might join, so all-in-all, the maintainers might +be more responsive to issues and pull requests! + +## Licensing? + +We know that news like this often fill developers with dread over commercialization and sudden license changes. Don't +worry - the license will stay exactly the same! + +## What WILL change? + +Metadata mostly, we’ll likely switch a few key-values in our manifests to better reflect the actual state of the +operator (i.e ownership, repository addresses, maintenance contacts etc) +In general, house-keeping stuff that doesn't really affect users. + +The primary change will be the repo address on Github, we'll migrate +the https://github.com/grafana-operator/grafana-operator to https://github.com/grafana. +Github automatically redirects migrated addresses, so there's nothing to be concerned about on that end. +Future OCI URI's will reflect this change, while existing artifacts will still have the same URI, they will be copied +over to our new home with the caveat, that digests will change. + +The documentation URL will also change, however, we will set up a redirect from it's current location, so it's likely +you won't even notice it moved! + +Perhaps, the biggest change to you, as a contributor to the grafana-operator, would be a new requirement to sign the +[Grafana CLA](https://grafana.com/docs/grafana/latest/developers/cla/), But worry not, this CLA is based on the +Apache Software Foundation CLA, which should put those of us whom are concerned about signing agreements, at ease. + +We might end up moving a few other things around, like creating a new channel on the upstream Grafana slack, however, +you'll definitely hear about any other changes before they happen! So, stay tuned! + +## Summary + +Thanks to everyone that supported us over the past 4 years, the project has really grown beyond expectation. From a +niche operator created for a very specific project, to a pretty sizeable community and a project that is now used by +many major companies throughout the world, some of whom you wouldn't expect, as they don't announce it publicly, but +contact us for support! + +We've got our hopes set high for this migration, and we hope you do too, let's take the operator to the next level! + +Thanks ~ Grafana Operator Maintainers From 859c1847f0438ffe3e5530e37f46c89d66feed5a Mon Sep 17 00:00:00 2001 From: Hubert Stefanski <35736504+HubertStefanski@users.noreply.github.com> Date: Mon, 27 Nov 2023 11:27:08 +0100 Subject: [PATCH 07/14] fix typo (#1319) --- docs/blog/operator-migration-to-upstream-grafana.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/blog/operator-migration-to-upstream-grafana.md b/docs/blog/operator-migration-to-upstream-grafana.md index 348a991bf..0079f455a 100644 --- a/docs/blog/operator-migration-to-upstream-grafana.md +++ b/docs/blog/operator-migration-to-upstream-grafana.md @@ -1,5 +1,5 @@ --- -author: "Hubert Stefańksi" +author: "Hubert Stefański" date: 2023-11-21 title: "Moving Upstream" linkTitle: "Grafana-Operator Moving Upstream" From 9261965be0bca9007d64e934545debd3c73816c2 Mon Sep 17 00:00:00 2001 From: Sonny <355656+sonnyg@users.noreply.github.com> Date: Tue, 28 Nov 2023 06:59:02 -0500 Subject: [PATCH 08/14] fix(deployment reconciler): Couldn't parse image reference "docker.io/grafana/grafana@9.1.6" (#1320) * use ':' for deployment image tag delimiter * rename 'setGrafanaImage' to 'getGrafanaImage' changing verb to 'get' since the function returns a value --- .../grafana/deployment_reconciler.go | 6 ++--- .../grafana/deployment_reconciler_test.go | 23 +++++++++++++++++++ 2 files changed, 26 insertions(+), 3 deletions(-) create mode 100644 controllers/reconcilers/grafana/deployment_reconciler_test.go diff --git a/controllers/reconcilers/grafana/deployment_reconciler.go b/controllers/reconcilers/grafana/deployment_reconciler.go index a57bc9569..972422635 100644 --- a/controllers/reconcilers/grafana/deployment_reconciler.go +++ b/controllers/reconcilers/grafana/deployment_reconciler.go @@ -133,10 +133,10 @@ func getVolumeMounts(cr *v1beta1.Grafana, scheme *runtime.Scheme) []v1.VolumeMou return mounts } -func setGrafanaImage() string { +func getGrafanaImage() string { grafanaImg := os.Getenv("RELATED_IMAGE_GRAFANA") if grafanaImg == "" { - grafanaImg = fmt.Sprintf("%s@%s", config2.GrafanaImage, config2.GrafanaVersion) + grafanaImg = fmt.Sprintf("%s:%s", config2.GrafanaImage, config2.GrafanaVersion) } return grafanaImg } @@ -144,7 +144,7 @@ func setGrafanaImage() string { func getContainers(cr *v1beta1.Grafana, scheme *runtime.Scheme, vars *v1beta1.OperatorReconcileVars, openshiftPlatform bool) []v1.Container { var containers []v1.Container - image := setGrafanaImage() + image := getGrafanaImage() plugins := model.GetPluginsConfigMap(cr, scheme) // env var to restart containers if plugins change diff --git a/controllers/reconcilers/grafana/deployment_reconciler_test.go b/controllers/reconcilers/grafana/deployment_reconciler_test.go new file mode 100644 index 000000000..786457f86 --- /dev/null +++ b/controllers/reconcilers/grafana/deployment_reconciler_test.go @@ -0,0 +1,23 @@ +package grafana + +import ( + "fmt" + "testing" + + config2 "github.com/grafana-operator/grafana-operator/v5/controllers/config" + + "github.com/stretchr/testify/assert" +) + +func Test_getGrafanaImage(t *testing.T) { + expectedDeploymentImage := fmt.Sprintf("%s:%s", config2.GrafanaImage, config2.GrafanaVersion) + + assert.Equal(t, expectedDeploymentImage, getGrafanaImage()) +} + +func Test_getGrafanaImage_withEnvironmentOverride(t *testing.T) { + expectedDeploymentImage := "I want this grafana image" + t.Setenv("RELATED_IMAGE_GRAFANA", expectedDeploymentImage) + + assert.Equal(t, expectedDeploymentImage, getGrafanaImage()) +} From 8f64b5ed2f5d8dd72a8e59102e71b8aa27e5bfeb Mon Sep 17 00:00:00 2001 From: Edvin N Date: Tue, 28 Nov 2023 13:05:36 +0100 Subject: [PATCH 09/14] prepare 5.5.2 (#1321) --- Makefile | 2 +- deploy/helm/grafana-operator/Chart.yaml | 2 +- deploy/helm/grafana-operator/README.md | 4 ++-- hugo/config.toml | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index 67129cdd3..a8d2ba8e1 100644 --- a/Makefile +++ b/Makefile @@ -2,7 +2,7 @@ # NOTE: this section almost matches outputs out kubebuilder v3.7.0 ### # Current Operator version -VERSION ?= 5.5.1 +VERSION ?= 5.5.2 # BUNDLE_GEN_FLAGS are the flags passed to the operator-sdk generate bundle command BUNDLE_GEN_FLAGS ?= -q --overwrite --version $(VERSION) $(BUNDLE_METADATA_OPTS) diff --git a/deploy/helm/grafana-operator/Chart.yaml b/deploy/helm/grafana-operator/Chart.yaml index 40081c816..33dca3f86 100644 --- a/deploy/helm/grafana-operator/Chart.yaml +++ b/deploy/helm/grafana-operator/Chart.yaml @@ -21,4 +21,4 @@ version: 0.1.1 # incremented each time you make changes to the application. Versions are not expected to # follow Semantic Versioning. They should reflect the version the application is using. # It is recommended to use it with quotes. -appVersion: "v5.5.1" +appVersion: "v5.5.2" diff --git a/deploy/helm/grafana-operator/README.md b/deploy/helm/grafana-operator/README.md index 163309d91..22e364687 100644 --- a/deploy/helm/grafana-operator/README.md +++ b/deploy/helm/grafana-operator/README.md @@ -7,14 +7,14 @@ linkTitle: "Helm installation" [grafana-operator](https://github.com/grafana-operator/grafana-operator) for Kubernetes to manage Grafana instances and grafana resources. -![Version: 0.1.1](https://img.shields.io/badge/Version-0.1.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v5.5.1](https://img.shields.io/badge/AppVersion-v5.5.1-informational?style=flat-square) +![Version: 0.1.1](https://img.shields.io/badge/Version-0.1.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v5.5.2](https://img.shields.io/badge/AppVersion-v5.5.2-informational?style=flat-square) ## Installation This is a OCI helm chart, helm started support OCI in version 3.8.0. ```shell -helm upgrade -i grafana-operator oci://ghcr.io/grafana-operator/helm-charts/grafana-operator --version v5.5.1 +helm upgrade -i grafana-operator oci://ghcr.io/grafana-operator/helm-charts/grafana-operator --version v5.5.2 ``` Sadly helm OCI charts currently don't support searching for available versions of a helm [oci registry](https://github.com/helm/helm/issues/11000). diff --git a/hugo/config.toml b/hugo/config.toml index 52b883c61..31b8d087e 100644 --- a/hugo/config.toml +++ b/hugo/config.toml @@ -59,7 +59,7 @@ archived_version = false # The version number for the version of the docs represented in this doc set. # Used in the "version-banner" partial to display a version number for the # current doc set. -version = "v5.5.1" +version = "v5.5.2" # A link to latest version of the docs. Used in the "version-banner" partial to # point people to the main doc site. From d1da4697a6c030f98acd0d0c55c51085cf1b61cc Mon Sep 17 00:00:00 2001 From: Razvan Sebastian Botez Date: Tue, 28 Nov 2023 14:26:36 +0200 Subject: [PATCH 10/14] Add namespace to templates. --- deploy/helm/grafana-operator/templates/cm.yaml | 1 + deploy/helm/grafana-operator/templates/deployment.yaml | 1 + deploy/helm/grafana-operator/templates/rbac.yaml | 8 ++++++++ deploy/helm/grafana-operator/templates/service.yaml | 1 + .../helm/grafana-operator/templates/serviceaccount.yaml | 1 + 5 files changed, 12 insertions(+) diff --git a/deploy/helm/grafana-operator/templates/cm.yaml b/deploy/helm/grafana-operator/templates/cm.yaml index c3f784713..cc4866e2d 100644 --- a/deploy/helm/grafana-operator/templates/cm.yaml +++ b/deploy/helm/grafana-operator/templates/cm.yaml @@ -3,6 +3,7 @@ apiVersion: v1 kind: ConfigMap metadata: name: {{ include "grafana-operator.fullname" . }} + namespace: {{ .Release.Namespace | quote }} labels: {{- with .Values.additionalLabels }} {{- toYaml . | nindent 4 }} diff --git a/deploy/helm/grafana-operator/templates/deployment.yaml b/deploy/helm/grafana-operator/templates/deployment.yaml index db3f2ff0f..b22be24e1 100644 --- a/deploy/helm/grafana-operator/templates/deployment.yaml +++ b/deploy/helm/grafana-operator/templates/deployment.yaml @@ -2,6 +2,7 @@ apiVersion: apps/v1 kind: Deployment metadata: name: {{ include "grafana-operator.fullname" . }} + namespace: {{ .Release.Namespace | quote }} labels: {{- include "grafana-operator.labels" . | nindent 4 }} {{- with .Values.additionalLabels }} diff --git a/deploy/helm/grafana-operator/templates/rbac.yaml b/deploy/helm/grafana-operator/templates/rbac.yaml index 2311fe385..ca9ebead0 100644 --- a/deploy/helm/grafana-operator/templates/rbac.yaml +++ b/deploy/helm/grafana-operator/templates/rbac.yaml @@ -9,7 +9,11 @@ apiVersion: rbac.authorization.k8s.io/v1 kind: {{ if not $namespaceScoped }}Cluster{{ end }}Role metadata: + {{- if $namespaceScoped }} + namespace: {{ $operatorNamespace }} + {{- else }} namespace: {{ . }} + {{- end }} name: grafana-operator-permissions labels: {{- include "grafana-operator.labels" $ | nindent 4 }} @@ -231,7 +235,11 @@ apiVersion: rbac.authorization.k8s.io/v1 kind: {{ if not $namespaceScoped }}Cluster{{ end }}RoleBinding metadata: name: grafana-operator-permissions + {{- if $namespaceScoped }} + namespace: {{ $operatorNamespace }} + {{- else }} namespace: {{ . }} + {{- end }} labels: {{- include "grafana-operator.labels" $ | nindent 4 }} {{- with $.Values.additionalLabels }} diff --git a/deploy/helm/grafana-operator/templates/service.yaml b/deploy/helm/grafana-operator/templates/service.yaml index 8aea0654a..f765c94bc 100644 --- a/deploy/helm/grafana-operator/templates/service.yaml +++ b/deploy/helm/grafana-operator/templates/service.yaml @@ -2,6 +2,7 @@ apiVersion: v1 kind: Service metadata: name: {{ include "grafana-operator.fullname" . }}-metrics-service + namespace: {{ .Release.Namespace | quote }} labels: {{- include "grafana-operator.labels" . | nindent 4 }} {{- with .Values.additionalLabels }} diff --git a/deploy/helm/grafana-operator/templates/serviceaccount.yaml b/deploy/helm/grafana-operator/templates/serviceaccount.yaml index 1c3ca8418..1b31f3130 100644 --- a/deploy/helm/grafana-operator/templates/serviceaccount.yaml +++ b/deploy/helm/grafana-operator/templates/serviceaccount.yaml @@ -3,6 +3,7 @@ apiVersion: v1 kind: ServiceAccount metadata: name: {{ include "grafana-operator.serviceAccountName" . }} + namespace: {{ .Release.Namespace | quote }} labels: {{- include "grafana-operator.labels" . | nindent 4 }} {{- with .Values.additionalLabels }} From 346bef57d46b2b2a95fc93655a307426ccbe1283 Mon Sep 17 00:00:00 2001 From: Razvan Sebastian Botez Date: Tue, 28 Nov 2023 15:20:25 +0200 Subject: [PATCH 11/14] increment version --- deploy/helm/grafana-operator/Chart.yaml | 2 +- deploy/helm/grafana-operator/README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/deploy/helm/grafana-operator/Chart.yaml b/deploy/helm/grafana-operator/Chart.yaml index 40081c816..9f7c4df9e 100644 --- a/deploy/helm/grafana-operator/Chart.yaml +++ b/deploy/helm/grafana-operator/Chart.yaml @@ -15,7 +15,7 @@ type: application # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. # Versions are expected to follow Semantic Versioning (https://semver.org/) -version: 0.1.1 +version: 0.1.2 # This is the version number of the application being deployed. This version number should be # incremented each time you make changes to the application. Versions are not expected to diff --git a/deploy/helm/grafana-operator/README.md b/deploy/helm/grafana-operator/README.md index 163309d91..81ac22a56 100644 --- a/deploy/helm/grafana-operator/README.md +++ b/deploy/helm/grafana-operator/README.md @@ -7,7 +7,7 @@ linkTitle: "Helm installation" [grafana-operator](https://github.com/grafana-operator/grafana-operator) for Kubernetes to manage Grafana instances and grafana resources. -![Version: 0.1.1](https://img.shields.io/badge/Version-0.1.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v5.5.1](https://img.shields.io/badge/AppVersion-v5.5.1-informational?style=flat-square) +![Version: 0.1.2](https://img.shields.io/badge/Version-0.1.2-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v5.5.1](https://img.shields.io/badge/AppVersion-v5.5.1-informational?style=flat-square) ## Installation From 997b54398db9564bb267f3779b4fbe9976619fee Mon Sep 17 00:00:00 2001 From: Razvan Sebastian Botez Date: Tue, 28 Nov 2023 15:27:58 +0200 Subject: [PATCH 12/14] fix docs --- deploy/helm/grafana-operator/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deploy/helm/grafana-operator/README.md b/deploy/helm/grafana-operator/README.md index 169485282..14bce0e49 100644 --- a/deploy/helm/grafana-operator/README.md +++ b/deploy/helm/grafana-operator/README.md @@ -7,7 +7,7 @@ linkTitle: "Helm installation" [grafana-operator](https://github.com/grafana-operator/grafana-operator) for Kubernetes to manage Grafana instances and grafana resources. -![Version: 0.1.2](https://img.shields.io/badge/Version-0.1.2-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v5.5.1](https://img.shields.io/badge/AppVersion-v5.5.1-informational?style=flat-square) +![Version: 0.1.2](https://img.shields.io/badge/Version-0.1.2-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v5.5.2](https://img.shields.io/badge/AppVersion-v5.5.2-informational?style=flat-square) ## Installation From 8791a7f29768d1d94469fb190750018f84216489 Mon Sep 17 00:00:00 2001 From: Razvan Sebastian Botez Date: Tue, 28 Nov 2023 15:36:19 +0200 Subject: [PATCH 13/14] remove namespace for cluster-scoped rbac --- deploy/helm/grafana-operator/templates/rbac.yaml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/deploy/helm/grafana-operator/templates/rbac.yaml b/deploy/helm/grafana-operator/templates/rbac.yaml index ca9ebead0..983e45e6c 100644 --- a/deploy/helm/grafana-operator/templates/rbac.yaml +++ b/deploy/helm/grafana-operator/templates/rbac.yaml @@ -11,8 +11,6 @@ kind: {{ if not $namespaceScoped }}Cluster{{ end }}Role metadata: {{- if $namespaceScoped }} namespace: {{ $operatorNamespace }} - {{- else }} - namespace: {{ . }} {{- end }} name: grafana-operator-permissions labels: @@ -237,8 +235,6 @@ metadata: name: grafana-operator-permissions {{- if $namespaceScoped }} namespace: {{ $operatorNamespace }} - {{- else }} - namespace: {{ . }} {{- end }} labels: {{- include "grafana-operator.labels" $ | nindent 4 }} From d1d71a9e4d1592b92232d5a61e766a683d5dce83 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 4 Dec 2023 09:14:18 +0100 Subject: [PATCH 14/14] chore(deps): bump tj-actions/changed-files from 40.1.1 to 40.2.0 (#1327) Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 40.1.1 to 40.2.0. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](https://github.com/tj-actions/changed-files/compare/25ef3926d147cd02fc7e931c1ef50772bbb0d25d...da093c1609db0edd0a037ce9664e135f74bf30d9) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/e2e.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/e2e.yaml b/.github/workflows/e2e.yaml index 9ea176767..0e35b570f 100644 --- a/.github/workflows/e2e.yaml +++ b/.github/workflows/e2e.yaml @@ -23,7 +23,7 @@ jobs: fetch-depth: 0 - id: changed-files name: Get changed files - uses: tj-actions/changed-files@25ef3926d147cd02fc7e931c1ef50772bbb0d25d #v40.1.1 + uses: tj-actions/changed-files@da093c1609db0edd0a037ce9664e135f74bf30d9 #v40.2.0 with: files_ignore: | **/*.md