-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend O11y / APM mapping: Allow overriding the service name through the Faro SDK #749
Comments
@cedricziel I think this would work great for us, but could I just clarify that this would apply both to the Span created when using the Tracing Instrumentation with Faro and the standard session-related logs, such as errors? My only other thought was whether you'd want to provide a more generic solution for adding/overriding attributes as part of this API, but for us, I think this would be enough as it is. If we wanted to add/update more attributes, they'd likely be to add info such as the name of the owning team, which can be derived by knowing the service name anyway. Therefore, having a |
The traces will have the updated service.name attribute, yes. We should probably think about enabling overrides for service.namespace and service.version as well. In my book the conversion here would be done by us in cloud (overriding the service.name attribute) and it would apply to all signals produced after the sdk method call. |
Yes - you can use that hook to inspect the full structure and make decisions based on it |
@cedricziel This all sounds good, thank you for prioritising it! |
Description
As a user of Frontend O11y and Application O11y in Grafana Cloud, i would like to override the service name
for a subset of telemetry as the user progresses through the UX.
Example:
login
servicecheckout
serviceprofile
service nameThe override should be persisted in the user session to allow maximum flexibility.
Proposed solution
Leverage the
setView
API and allow to override the context.Example:
Context
The text was updated successfully, but these errors were encountered: