Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faro should not create a new session when calling setSession() to only change attributes within a valid session #718

Open
codecapitano opened this issue Oct 29, 2024 · 0 comments
Labels
bug Report a bug

Comments

@codecapitano
Copy link
Collaborator

Why

When calling the setSession() to dynamically update session attributes, Faro always creates a new sessionId.
The session updater function shouldn't create a new sessionId if only attributes changed within a valid session.
A valid session is a session which neither reached the max lifetime or max inactivity time thresholds.

What

  • setSession() should only auto create a new sessionId if a session is invalid or if the caller provided a new sessionId.
@codecapitano codecapitano added the bug Report a bug label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report a bug
Projects
None yet
Development

No branches or pull requests

1 participant