Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traceparent header is still added to requests when the faro instance is paused #710

Open
raresfelecan opened this issue Oct 17, 2024 · 0 comments
Labels
bug Report a bug

Comments

@raresfelecan
Copy link

raresfelecan commented Oct 17, 2024

Description

Pausing the faro instance does not pause the tracing instrumentation -> traceparent header is still added to requests

Steps to reproduce

  1. Init faro
  2. Pause faro .pause()
  3. Make any request
  4. Notice the tracing instrumentation from OpenTelemetry is not paused -> traceparent header is still added to those requests

Expected behavior

When the faro instance is in the paused state, tracing instrumentation should also be paused (don't add traceparent header on following requests).

Actual behavior

When the faro instance is in the paused state, tracing instrumentation is NOT paused (traceparent header is still added to the following requests).

Environment

  • SDK version: 1.10.0
  • SDK instrumentations: ReactIntegration, TracingInstrumentation, ViewInstrumentation, SessionInstrumentation, WebVitalsInstrumentation, ErrorsInstrumentation, PerformanceInstrumentation
  • Device type: laptop
  • Device name: Macbook Pro 16-inch, 2023
  • OS: Sonoma 14.6.1
  • Browser: Chrome Version 128.0.6613.138 (Official Build) (arm64)

Context

Having some customers that don't want any kind of tracking enabled (switched dinamically) and seeing the traceparent header on requests might get them suspicious.

@raresfelecan raresfelecan added the bug Report a bug label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report a bug
Projects
None yet
Development

No branches or pull requests

1 participant