Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flagext: add intstring type #616

Closed
wants to merge 4 commits into from
Closed

Conversation

titolins
Copy link
Contributor

@titolins titolins commented Nov 6, 2024

What this PR does:

  • Adds a new IntString type to be used for configuration values

Which issue(s) this PR fixes:

Checklist

  • Tests updated
  • CHANGELOG.md updated

@titolins titolins force-pushed the titolins/add-intstring-flagext branch from 53bec21 to 7ebd8a0 Compare November 6, 2024 11:25
@titolins
Copy link
Contributor Author

titolins commented Nov 8, 2024

We've decided to use flagext.Bytes instead of introducing a new type: grafana/mimir#9845

@titolins titolins closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant