Make flagext pkg consistent across different projects

[kavirajk]

Currently Loki uses, its own version of flagext package

Should we also bring this to dskit?

One of the rationale from my side personally is, it will make entitlement system validation simpler. Having it in single place. e.g: I can implement custom JSON unmarshalling for these types in one place.

[aknuds1]

You mean to port improvements from Loki's flagext package to dskit?

[kavirajk]

Yes!. that's right.

Would be great if all GL projects (like Loki, Tempo, Cortex) uses same flagext package.

[56quarters]

@kavirajk The flagext from Cortex was already ported to dskit. What specifically is the one in dskit missing compared to loki's copy?

I'm closing this since Loki has already been updated to use the version from DSKit: grafana/loki#4225

[kavirajk]

@56quarters Loki still have its custom version of flagext (already mentioned in the description) and its still using it. My point is we should bring that also into dskit. And Loki should use only flagext from dskit!.

[pracucci]

@56quarters Loki still have its custom version of flagext (already mentioned in the description) and its still using it. My point is we should bring that also into dskit. And Loki should use only flagext from dskit!.

I think it depends on what we wanna port. Is the data type specific to Loki? Then I would keep it in Loki. Is the data type generic (ex. human bytes) then we can move it to dskit if can benefit other projects too.