Skip to content

Commit

Permalink
Merge pull request #104 from grafana/chore/remove-math
Browse files Browse the repository at this point in the history
Remove package math
  • Loading branch information
aknuds1 authored Dec 23, 2021
2 parents 1f49a70 + f47fcf5 commit 1a0e224
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 141 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
* [CHANGE] spanlogger: Take interface implementation for extracting tenant ID. #59
* [CHANGE] The `status_code` label on gRPC client metrics has changed from '200' and '500' to '2xx', '5xx', '4xx', 'cancel' or 'error'. #68
* [CHANGE] Memberlist: changed probe interval from `1s` to `5s` and probe timeout from `500ms` to `2s`. #90
* [CHANGE] Remove package `math`. #104
* [ENHANCEMENT] Add middleware package. #38
* [ENHANCEMENT] Add the ring package #45
* [ENHANCEMENT] Add limiter package. #41
Expand Down
2 changes: 1 addition & 1 deletion concurrency/runner.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (

"golang.org/x/sync/errgroup"

"github.com/grafana/dskit/math"
"github.com/grafana/dskit/internal/math"
"github.com/grafana/dskit/multierror"
)

Expand Down
9 changes: 9 additions & 0 deletions internal/math/math.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
package math

// Min returns the minimum of two ints.
func Min(a, b int) int {
if a < b {
return a
}
return b
}
33 changes: 0 additions & 33 deletions math/math.go

This file was deleted.

59 changes: 0 additions & 59 deletions math/rate.go

This file was deleted.

47 changes: 0 additions & 47 deletions math/rate_test.go

This file was deleted.

2 changes: 1 addition & 1 deletion ring/ring.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import (
"github.com/grafana/dskit/services"

"github.com/grafana/dskit/flagext"
dsmath "github.com/grafana/dskit/math"
dsmath "github.com/grafana/dskit/internal/math"
)

const (
Expand Down

0 comments on commit 1a0e224

Please sign in to comment.