Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an "experimental" flag for rules #185

Open
rgeyer opened this issue Jul 10, 2024 · 2 comments
Open

Add an "experimental" flag for rules #185

rgeyer opened this issue Jul 10, 2024 · 2 comments

Comments

@rgeyer
Copy link
Collaborator

rgeyer commented Jul 10, 2024

New rules, particularly ones which replace deprecated rules (see #184) should be introduced with an "experimental" flag.

Experimental rules would not be added/run automatically

Experimental rules can be enabled with a CLI flag. This would allow users to "dry run" the latest changes against their dashboards/repositories.

@alex5517
Copy link

@rgeyer,

As for selectively enabling experimental rules, instead of enabling all rules by providing an "experimental" flag.
Would we not be able to "avoid" the config check, warning text etc. if we turn it around and let it work the same way as the "stable" rules does?

So if one would want to use 2 out of 3 experimental rules, then they use the "experimental" flag and then create an exclusion for the experimental rule they do not want?

@rgeyer
Copy link
Collaborator Author

rgeyer commented Jul 12, 2024

@rgeyer,

As for selectively enabling experimental rules, instead of enabling all rules by providing an "experimental" flag. Would we not be able to "avoid" the config check, warning text etc. if we turn it around and let it work the same way as the "stable" rules does?

So if one would want to use 2 out of 3 experimental rules, then they use the "experimental" flag and then create an exclusion for the experimental rule they do not want?

Right, excellent point. I wrote this up in a hurry and didn't think through it. I think your solution makes the most sense.

I'll update the issue accordingly. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants