Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace weaveworks/common by grafana/dskit #5273

Closed
wildum opened this issue Sep 22, 2023 · 0 comments · Fixed by #5274
Closed

Replace weaveworks/common by grafana/dskit #5273

wildum opened this issue Sep 22, 2023 · 0 comments · Fixed by #5274
Assignees
@wildum
Labels
bug Something isn't working frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.

Comments

@wildum
Copy link
Contributor

wildum commented Sep 22, 2023

In grafana/dskit#342 weaveworks/common was moved to dskit.

In the agent we currently use both github.com/weaveworks/common and github.com/grafana/dskit which means that some pkg are duplicated resulting in this error:

2023/09/22 09:38:56 proto: duplicate proto type registered: httpgrpc.HTTPRequest
2023/09/22 09:38:56 proto: duplicate proto type registered: httpgrpc.HTTPResponse
2023/09/22 09:38:56 proto: duplicate proto type registered: httpgrpc.Header

We should get rid of github.com/weaveworks/common
@wildum wildum added bug Something isn't working type/infrastructure labels Sep 22, 2023
@wildum wildum self-assigned this Sep 22, 2023
@wildum wildum mentioned this issue Sep 22, 2023
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Grafana Agent (Public) Sep 22, 2023
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@wildum wildum

Labels
bug Something isn't working frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
No open projects
Grafana Agent (Public)
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace weaveworks common by dskit grafana/agent
1 participant
@wildum