Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading grafana to 11.0.0 breaks smartquery subsystem #180

Open
hbaghar opened this issue Aug 5, 2024 · 2 comments
Open

Upgrading grafana to 11.0.0 breaks smartquery subsystem #180

hbaghar opened this issue Aug 5, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@hbaghar
Copy link

hbaghar commented Aug 5, 2024

Describe the bug
On upgrading my grafana instance to v11.0.0 I can no longer use some scripts I had created to create snapshots of my dashboards. Only thing I have noticed so far is that I can no longer able to make postgresql queries using smartquery

To Reproduce
Steps to reproduce the behavior:

  1. Make postgresql query call using smartquery
  2. Observe error
  File "/Users/miniconda3/envs/my-env/lib/python3.9/site-packages/grafana_client/elements/datasource.py", line 349, in smartquery
    request = query_factory(datasource, model)
  File "/Users/miniconda3/envs/my-env/lib/python3.9/site-packages/grafana_client/knowledge.py", line 423, in query_factory
    raise NotImplementedError(f"Unknown data source type: {datasource_type}")
NotImplementedError: Unknown data source type: grafana-postgresql-datasource

Expected behavior
Function should return a response with data from my postgresql datasource

Versions

  • Grafana: [ 11.0.0]
  • grafana-client: [4.1.0 ]
  • Authentication: [Token]

Additional context
Unclear at this point if there are more breaking changes. I know that the latest release of this package supports only up to grafana 10.x. I wanted to know if we have any visibility on a newer release for this package that will resolve these issues.

@amotl
Copy link
Contributor

amotl commented Sep 16, 2024

Dear @hbaghar,

thanks a stack for your report. The "smartquery" subsystem is a bit secondary to grafana-client, nevertheless we sure enough would like to see this issue fixed. Have you been able to come up with a solution how to fix this in one way or another?

With kind regards,
Andreas.

@amotl
Copy link
Contributor

amotl commented Sep 16, 2024

Unclear at this point if there are more breaking changes. I know that the latest release of this package supports only up to grafana 10.x. I wanted to know if we have any visibility on a newer release for this package that will resolve these issues.

As far as grafana-wtf covers the grafana-client API, the library should be well compatible with Grafana 11.

@amotl amotl changed the title Upgrading grafana to 11.0.0 breaks code Upgrading grafana to 11.0.0 breaks smartquery subsystem Sep 30, 2024
@amotl amotl added the bug Something isn't working label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants